ungoogled-chromium,chromium+llvm: use versionhistory.googleapis.com over omahaproxy.appspot.com, fix various update script issues #225281
Conversation
There was a problem hiding this comment.
The llvm scirpt works as expected and looks good to me, also didn't find any other references to history that weren't edited to releases.
But the chromium scirpt has a problems for me:
For downloading with prefatch-nix it creates a tmpfs which is not large-enough for the file it want's to download and causes the download to crash, because it thinks there is not enough space left.
output of df -h:
tmpfs 1,6G 1,6G 0 100% /run/user/1000
Error message:
error: writing to file: No space left on device
It then restarts the download which crashes with the same error and just ends up looping
In another PR someone should fix the deprecation warning:
~/Projects/nixos/nixpkgs/./pkgs/applications/networking/browsers/chromium/update.py:18: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
As services.logind.extraConfig = ''
RuntimeDirectorySize=25%
''; |
This should probably be in the README.md updating part, because I assume that might be a common error people will encounter. |
networkException
force-pushed
the
deprecate-omahaproxy
branch
from
91db126
to
fd01c99
Compare
networkException
changed the title
|
Tested both scripts, they work fine now. The latest commit fixed the problem with the update script trying to pull windows only releases. |
networkException
force-pushed
the
deprecate-omahaproxy
branch
from
ba047b3
to
6bf2f9b
Compare
|
Since Google just bumped the stable channel for Linux to 112.0.5615.121 I noticed another issue: Before the last push the script would only fetch the newest release from each channel, causing the code that filters ungoogled-chromium releases to the Linux stable channel to fail. With the newest changes, the script will now fetch all releases for all Linux channels. Note that Google's CI has not finished publishing release tarballs for 112.0.5615.121, the stable channel currently fails to update. Also note that the latest ungoogled-chromium release in nixpkgs is a Windows only release, meaning that running the script now would revert ungoogled-chromium back one version to .49. It should work properly once I push ungoogled-chromium release |
networkException
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2103 |
| api_tag_url = 'https://api.github.com/repos/Eloston/ungoogled-chromium/tags?per_page=1' | ||
| def get_latest_ungoogled_chromium_tag(linux_stable_versions): | ||
| """Returns the latest ungoogled-chromium tag for linux using the GitHub API.""" | ||
| api_tag_url = 'https://api.github.com/repos/ungoogled-software/ungoogled-chromium/tags' |
There was a problem hiding this comment.
Does this take a github token?
There was a problem hiding this comment.
I mean technically yes but I would assume that the package maintainers don't run the script to an extent that would require a token
There was a problem hiding this comment.
The rate limiting is per IP for the entire API. If you are in a shared space then the rate limiting is often very quickly hit.
There was a problem hiding this comment.
So you want an optional flag that passes a github api token to the program?
There was a problem hiding this comment.
It would be great if it just takes one from GITHUB_TOKEN env.
Version information previously available at omahaproxy.appspot.com will have to be retrieved from versionhistory.googleapis.com in the future. See https://groups.google.com/a/chromium.org/g/chromium-dev/c/uH-nFrOLWtE/m/PhUj_inyAQAJ See ungoogled-software/ungoogled-chromium#2260
Version information previously available at omahaproxy.appspot.com will have to be retrieved from versionhistory.googleapis.com in the future. See https://groups.google.com/a/chromium.org/g/chromium-dev/c/uH-nFrOLWtE/m/PhUj_inyAQAJ See ungoogled-software/ungoogled-chromium#2260
The main repository has moved from the Eloston user to the ungoogled-software organisation.
ungoogled-chromium releases generally follow the chromium stable channel, however as the patchset targets Linux, macOS and Windows, a release might not always be intended for being packaged in nix. This patch patches the update script to filter ungoogled-chromium releases by them being available as stable releases for Linux.
networkException
force-pushed
the
deprecate-omahaproxy
branch
from
6bf2f9b
to
81a44e0
Compare
Description of changes
This pull request updates chromium's update.py and llvms update-git.py script to use the versionhistory.googleapis.com api as a replacement for the now deprecated omahaproxy.appspot.com.
See https://groups.google.com/a/chromium.org/g/chromium-dev/c/uH-nFrOLWtE/m/PhUj_inyAQAJ for the deprecation notice and ungoogled-software/ungoogled-chromium#2260 for a discussion about the query parameters used.
Additionally, it fixes some issues related to the ungoogled-chromium packaging, namely that the update.py script would update to Windows only releases. The script will now only update to ungoogled-chromium releases matching the Linux stable channel.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)