Ignore text-icu tests on Darwin #2254
Conversation
The normalization test fails, but this doesn't stop the library for being useful. I will open another issue against text-icu itself for the normalization failure.
|
This was already opened by ocharles in haskell/text-icu#6 |
|
Manual edits to cabal2nix-generated files are lost when the package is updated. It would be best to add the appropriate know-how to cabal2nix's post-processing function. See line 17 in that file for an example of how that's done. Once cabal2nix know about this setting, an automatic re-generation process gets that update into the expression in Nixpkgs. (The same process that drops the change if it's not registered in cabal2nix.) |
|
Can we add a comment to the top of autogenerated haskell packages with the warning that they would be overwritten and a pointer to instructions on patching cabal2nix? |
|
Yes, that's certainly a good idea. |
| @@ -7,6 +7,7 @@ cabal.mkDerivation (self: { | |||
| version = "0.6.3.7"; | |||
| sha256 = "0mzzjamcxfrld9xwgdww3890zzkgmi1qb83v5z9zrixmdgwkvhf4"; | |||
| buildDepends = [ text ]; | |||
| doCheck = !stdenv.isDarwin; | |||
There was a problem hiding this comment.
Note that stdenv can be accessed as self.stdenv in Cabal derivations.
|
I've adopted cabal2nix in NixOS/cabal2nix@66b710d and merged the commit. |
The normalization test fails, but this doesn't stop the library for being useful. I will open another issue against text-icu itself for the normalization failure.