Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-cache: init at 2018-06-18 #227295

Merged
merged 3 commits into from
Nov 26, 2023
Merged

git-cache: init at 2018-06-18 #227295

merged 3 commits into from
Nov 26, 2023

Conversation

MaxHearnden
Copy link
Contributor

Description of changes

Adds git-cache a program to add and manage a system-wide or user-wide cache for remote git repositories

https://github.com/Seb35/git-cache

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@xanderio xanderio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for packing this :)

The biggest thing that's blocking this from getting merged is that meta.mainainers isn't set, as required per CONTRIBUTING.md

@xanderio
Copy link
Contributor

Result of nixpkgs-review pr 227295 run on x86_64-linux 1

1 package built:
  • git-cache

MaxHearnden added a commit to MaxHearnden/nixpkgs that referenced this pull request May 24, 2023
The issues can be found at NixOS#227295.
The review was quite helpful.
The issues can be found at NixOS#227295.
The review was quite helpful.
@ehmry ehmry merged commit 089df4e into NixOS:master Nov 26, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants