gtest: 1.12.1 -> 1.13.0

[cbourjau]

Description of changes

Update gtest (googletest) to its latest release (changelog).

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[trofi]

Bisect says 2bb0f80 gtest: 1.12.1 -> 1.13.0 broke protobuf on staging as:

$ nix build --no-link -f. -L protobuf
...
protobuf> /build/source/third_party/googletest/googletest/include/gtest/internal/gtest-port.h:270:2: error: #error C++ versions less than C++14 are not supported.
protobuf>   270 | #error C++ versions less than C++14 are not supported.
protobuf>       |  ^~~~~

Looks like googletest wants at least c++14 while protobuf forces c++11 .

[trofi]

Probably fixed upstream in protocolbuffers/protobuf@7df94e2

[SuperSandro2000]

Do we want to add protobuf to gtest passthru.tests?

[cbourjau]

Do we want to add protobuf to gtest passthru.tests?

I'm afraid I'm not sure what this entails.

[SuperSandro2000]

That ofborg will try to build it and we catch regressions early, nothing else.

[vcunat]

I believe we should revert this PR from 23.05. Just one glance at the announcement shows breaking change which caused this issue:

GoogleTest now requires at least C++14

Breaking changes aren't allowed now (and weren't around merge time), as seen in #223562

/cc #231026

[vcunat]

Packages broken by this, for future reference (will be edited):

• protobuf https://hydra.nixos.org/build/219405220
• rapidjson https://hydra.nixos.org/build/219435297

[vcunat]

I reverted the update. We can merge it again after forking off NixOS 23.05 (scheduled to May 22), though at once with fixes for these known regressions at least.

[cbourjau]

I reverted the update. We can merge it again after forking off NixOS 23.05 (scheduled to May 22), though at once with fixes for these known regressions at least.

Is there a reasonable way forward to get gtest up-to-day? Nixpkgs supports several versions of protobuf.Does this mean/is the way forward to also support various versions of gtest for the time being?