Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mathcomp 1.16.0 -> 1.17.0 #230891

Merged
merged 4 commits into from
May 23, 2023
Merged

Mathcomp 1.16.0 -> 1.17.0 #230891

merged 4 commits into from
May 23, 2023

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented May 9, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from vbgl, jwiegley and CohenCyril May 9, 2023 17:19
@CohenCyril CohenCyril mentioned this pull request May 17, 2023
Merged
@proux01
Copy link
Contributor Author

proux01 commented May 17, 2023

@CohenCyril successfully tested on coq-community/coq-nix-toolbox#146

@proux01 proux01 marked this pull request as ready for review May 17, 2023 16:04
@proux01
Copy link
Contributor Author

proux01 commented May 23, 2023

@vbgl successfully tested on coq-community/coq-nix-toolbox#146 I think this can be merged

@vbgl vbgl merged commit 499cad7 into NixOS:master May 23, 2023
@github-actions github-actions bot mentioned this pull request May 23, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@github-actions
Copy link
Contributor

Git push to origin failed for release-23.05 with exitcode 1

1 similar comment
@github-actions
Copy link
Contributor

Git push to origin failed for release-23.05 with exitcode 1

@proux01
Copy link
Contributor Author

proux01 commented May 23, 2023

Thanks!

@proux01 proux01 deleted the update-mathcomp-1.17.0 branch May 23, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl Awaiting requested review from vbgl

@jwiegley jwiegley Awaiting requested review from jwiegley

@CohenCyril CohenCyril Awaiting requested review from CohenCyril

Assignees
No one assigned
Labels
6.topic: coq 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proux01 @vbgl