pythonPackages.pythonefl: broken only with python 3.11 #231956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: Enlightenment DE
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2244 |
romildo
changed the title
| broken = true; | ||
| # The generated files in the tarball aren't compatible with python 3.11 | ||
| # See https://sourceforge.net/p/enlightenment/mailman/message/37794291/ | ||
| broken = python.pythonAtLeast "3.11"; |
There was a problem hiding this comment.
This should have been disabled using disable
There was a problem hiding this comment.
Any documentation or example on how to do it with disable?
There was a problem hiding this comment.
disable = python at least "3.11";
Just ripgrep the code and you'll find some examples :)
|
Can we backport this change to 23.05 ? |
|
Successfully created backport PR for |
1 task
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The generated files in the tarball aren't compatible only with python 3.11
See https://sourceforge.net/p/enlightenment/mailman/message/37794291/
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)