Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pythonefl: broken only with python 3.11 #231956

Merged
merged 1 commit into from
May 23, 2023
Merged

pythonPackages.pythonefl: broken only with python 3.11 #231956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkgs/development/python-modules/python-efl/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ buildPythonPackage rec {
platforms = platforms.linux;
license = with licenses; [ gpl3 lgpl3 ];
maintainers = with maintainers; [ matejc ftrvxmtrx ] ++ teams.enlightenment.members;
broken = true;
# The generated files in the tarball aren't compatible with python 3.11
# See https://sourceforge.net/p/enlightenment/mailman/message/37794291/
broken = python.pythonAtLeast "3.11";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been disabled using disable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any documentation or example on how to do it with disable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

disable = python at least "3.11";

Just ripgrep the code and you'll find some examples :)

};
}