fmt: 9.1.0 -> 10.0.0 #233330
Merged
fmt: 9.1.0 -> 10.0.0 #233330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clasp is not compatible with fmt 10 yet.
|
Result of 2 packages marked as broken and skipped:
243 packages failed to build:
60 packages built:
|
|
spdlog has patches upstream: gabime/spdlog#2694 gabime/spdlog#2736 |
alyssais
approved these changes
May 25, 2023
babariviere
approved these changes
May 25, 2023
|
Result of 41 packages marked as broken and skipped:
169 packages failed to build:
97 packages built:
|
|
This is laying around for around a month now with no further complains and two approvals so I will merge this. |
|
So, as the nixpkgs-review above suggested, this broke lots of packages, apparently most of this diff: |
|
Uff I'm sorry 😔 |
|
Sorry about that, I totally forgot about reviewing the failures. I think we can solve most the breakages by pinning spdlog to fmt 9 #240270 |
|
I've got another PR to fix a build failure here: #240338 |
|
Fix for coeurl (nheko dependency) is in #240698 . |
|
iptsd package is not building too with an error mentioning this. |
|
Sorry about that, iptsd should be fixed by #241229 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/fmtlib/fmt/releases/tag/10.0.0
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)