nixos/qemu-vm: add virtualisation.memorySize < 2048 assertion on 32bit
#234266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssais
approved these changes
May 27, 2023
RaitoBezarius
approved these changes
May 27, 2023
1 task
|
Successfully created backport PR for |
|
This appears to be breaking nixos tests for me on nixos x86_64 #234399 (comment) |
risicle
reviewed
May 27, 2023
| @@ -863,7 +863,13 @@ in | |||
| The address must be in the default VLAN (10.0.2.0/24). | |||
| ''; | |||
| } | |||
| ])); | |||
| ])) ++ [ | |||
| { assertion = pkgs.stdenv.hostPlatform.is32bit && cfg.memorySize < 2047; | |||
There was a problem hiding this comment.
I think this should be pkgs.stdenv.hostPlatform.is32bit -> cfg.memorySize < 2047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See #230871 and https://matrix.to/#/!aGqRytqbCECitOFhbt:nixos.org/$06Z4JhUEJ8RYmnq-QOvFQvieQMrgwk7uy17VmWKr7KE?via=nixos.org&via=matrix.org
cc @RaitoBezarius
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)