Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce: add screenLock option #23492

Merged
merged 1 commit into from
Mar 7, 2017
Merged

xfce: add screenLock option #23492

merged 1 commit into from
Mar 7, 2017

Conversation

zarelit
Copy link
Member

@zarelit zarelit commented Mar 4, 2017

Motivation for this change

screenLock option is needed to provide at least one application for xflock4 to lock the screen.

Closes #16845

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

screenLock option is needed to provide at least one application for
xflock4 to lock the screen
@mention-bot
Copy link

@zarelit, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @abbradar and @peti to be potential reviewers.

@grahamc grahamc merged commit 710973e into NixOS:master Mar 7, 2017
@grahamc
Copy link
Member

grahamc commented Mar 7, 2017

Thank you!

@Baughn
Copy link
Contributor

Baughn commented Mar 28, 2017

This seems to have caused a fun new bug in my system.

Basically, if you have xlockmore installed in the user environment -- as you would, to make xfce screen-lock work -- then, with this change, the screensaver becomes unable to unlock itself. I have no idea how this could possibly be, but it's fixed by nix-env -e xlockmore.

My first suspicion was pam, as the pam input is optional in the xlockmore recipe, but both of the xlockmore binaries on my system link against pam.

@Baughn
Copy link
Contributor

Baughn commented Mar 28, 2017

Some stracing found the problem: For whatever reason, with xlockmore installed in my user profile, it's calling unix_chkpwd for root instead of, well, me.

I'm really quite terribly confused now.

@zarelit
Copy link
Member Author

zarelit commented Apr 5, 2017

@Baughn Did you do further investigation or just removed xlockmore from your user profile?

@Baughn
Copy link
Contributor

Baughn commented Apr 6, 2017

@zarelit I removed xlockmore from my user profile.

@lukateras lukateras added the 6.topic: xfce The Xfce Desktop Environment label Dec 18, 2017
@zarelit zarelit deleted the xfce_lockscreen branch June 25, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to lock screen in xfce
6 participants