Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thanos: fix build go1.20 and unpin go #235916

Merged
merged 1 commit into from
Jun 4, 2023
Merged

thanos: fix build go1.20 and unpin go #235916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pkgs/servers/monitoring/thanos/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ lib, buildGoModule, fetchFromGitHub }:
{ lib, buildGoModule, fetchFromGitHub, fetchpatch }:
buildGoModule rec {
pname = "thanos";
version = "0.31.0";
Expand All @@ -10,7 +10,15 @@ buildGoModule rec {
sha256 = "sha256-EJZGc4thu0WhVSSRolIRYg39S81Cgm+JHwpW5eE7mDc=";
};

vendorHash = "sha256-bNQwDttJ7YuQFrpp0alqe37/lue0CX5gB2UDRWWtTXQ=";
patches = [
# https://github.com/thanos-io/thanos/pull/6126
(fetchpatch {
url = "https://github.com/thanos-io/thanos/commit/a4c218bd690259fc0c78fe67e0739bd33d38541e.patch";
hash = "sha256-Hxc1s5IXAyw01/o4JvOXuyYuOFy0+cBUv3OkRv4DCXs=";
})
];

vendorHash = "sha256-8+MUMux6v/O2syVyTx758yUBfJkertzibz6yFB05nWk=";

doCheck = true;

Expand Down
6 changes: 1 addition & 5 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26408,11 +26408,7 @@ with pkgs;

tailspin = callPackage ../tools/misc/tailspin { };

thanos = callPackage ../servers/monitoring/thanos {
# Fails to run with go1.20 due to go4.org/unsafe/assume-no-moving-gc not being
# update to be compatible with Go 1.20
buildGoModule = buildGo119Module;
};
thanos = callPackage ../servers/monitoring/thanos { };

trafficserver = callPackage ../servers/http/trafficserver { };

Expand Down