haskell: ghcjs shims: dc034a0 -> b970152 #23611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haskell.compiler.ghcjs
is currently broken due totasty-ant-xml
, where we are waiting for a newer version to be picked up by hackage2nix.But
haskell.compiler.ghcjsHEAD
builds and of course I testedghcjs
with a fewer other local fixes.Motivation for this change
There are some important fixes in there. I was bitten in particular by wrongly translated file permissions in the
base
shim, which is fixed now.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)