Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell: ghcjs shims: dc034a0 -> b970152 #23611

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Conversation

ljli
Copy link
Contributor

@ljli ljli commented Mar 7, 2017

haskell.compiler.ghcjs is currently broken due to tasty-ant-xml, where we are waiting for a newer version to be picked up by hackage2nix.
But haskell.compiler.ghcjsHEAD builds and of course I tested ghcjs with a fewer other local fixes.

Motivation for this change

There are some important fixes in there. I was bitten in particular by wrongly translated file permissions in the base shim, which is fixed now.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ljli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @waern and @cstrahan to be potential reviewers.

@peti peti merged commit 83df89a into NixOS:master Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants