blueprint-compiler: 0.6.0 -> 0.8.1

[BenediktBroich]

Description of changes

v0.8.1

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[BenediktBroich]

So this update will break 2 (giara textpieces) of 20 (bottles bottles-unwrapped denaro dialect dynamic-wallpaper elastic giara gnome-extension-manager gradience halftone health identity imaginer junction raider tangram textpieces video-trimmer whatip) packages that depend on blueprint-compiler.

How do i proceed with this? Do i have to patch these packages in this pr?

Notify maintainer:

• giara @dasj19
• textpieces @zendo

20 packages updated:
blueprint-compiler (0.6.0 → 0.8.1) bottles bottles-unwrapped denaro dialect dynamic-wallpaper elastic giara gnome-extension-manager gradience halftone health identity imaginer junction raider tangram textpieces video-trimmer whatip

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/bene/.cache/nixpkgs-review/rev-12239f8be59ef127ca04c2a8243555a39bdf271d/build.nix
error: builder for '/nix/store/h065kmrjbs7kjz9sn08i3m76wn4gjlpm-giara-1.0.1.drv' failed with exit code 1;
       last 10 log lines:
       >   26 |        item { custom: profile; }
       >      |                       ^
       >
       > error: Unexpected tokens
       > at ../data/ui/headerbar.blp line 26 column 22:
       >   26 |        item { custom: profile; }
       >      |                     ^
       >
       > 2 errors
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/h065kmrjbs7kjz9sn08i3m76wn4gjlpm-giara-1.0.1.drv'.
error: builder for '/nix/store/lcy9gc3g9mf1y089qg75v3pmxd3zlzvw-textpieces-3.4.0.drv' failed with exit code 1;
       last 10 log lines:
       > at ../resources/ui/CustomToolPage.blp line 43 column 3:
       >   43 |  .TextPiecesToolSettings tool_settings {
       >      |  ^
       >
       > error: Cannot convert 2.5 to integer
       > at ../resources/ui/Editor.blp line 45 column 26:
       >   45 |          margin-bottom: 2.5;
       >      |                         ^
       >
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/lcy9gc3g9mf1y089qg75v3pmxd3zlzvw-textpieces-3.4.0.drv'.
error: 2 dependencies of derivation '/nix/store/b9d57n4nsj2l9yhvb22z9ydm1n2v7516-review-shell.drv' failed to build
2 packages failed to build:
giara textpieces

18 packages built:
blueprint-compiler bottles bottles-unwrapped denaro dialect dynamic-wallpaper elastic gnome-extension-manager gradience halftone health identity imaginer junction raider tangram video-trimmer whatip

[dasj19]

Hi @BenediktBroich it seems like "giara" expects version 0.6 of blueprint-compiler, I even tried bumping the version of giara to 1.1.0 but it still relies on version 0.6 of blueprint-compiler.
So I guess we have to ask upstream for 0.8 support.
As I unfortunately don't have much spare time at the moment, and I no longer use giara, maybe we should consider dropping giara from nixpkgs so you can carry on with the update of blueprint-compiler.

EDIT: it seems like the change is non-trivial and I got giara to work with blueprint 0.8. So I opened PR #238409 which works with both version 0.6 and 0.8. So after that is merged there should no longer be a blocker for your PR. Thanks.

[SuperSandro2000]

How do i proceed with this? Do i have to patch these packages in this pr?

or mark it broken

[BenediktBroich]

How do i proceed with this? Do i have to patch these packages in this pr?

or mark it broken

inside this pr?

[Janik-Haag]

This should be two commits as far as I can tell.
One marking textpieces broken in the newer version, and one updating blueprint-compiler.

Otherwise this looks good.

[Janik-Haag]

LGTM