nmap: 7.93 -> 7.94 #238960
Merged
nmap: 7.93 -> 7.94 #238960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
approved these changes
Jun 22, 2023
|
this breaks cross compilation: $ git show ddf2d4e8ea0109225caaea58c5e666a38c492279
nmap: 7.93 -> 7.94
$ git checkout ddf2d4e8ea0109225caaea58c5e666a38c492279~1
$ nix build '.#pkgsCross.aarch64-multiplatform.nmap'
<success>
$ git checkout ddf2d4e8ea0109225caaea58c5e666a38c492279
$ nix build '.#pkgsCross.aarch64-multiplatform.nmap'
...
make[1]: Leaving directory '/build/nmap-7.94/libnetutil'
aarch64-unknown-linux-gnu-g++ -c -I./liblinear -I./liblua -I/nix/store/b6dc0lljn4lkylyrv3mj8z4bfslafxj1-lua-aarch64-unknown-linux-gnu-5.3.6/include -I./libdnet-stripped/include -I./libz -I./nbase -I./nsock/include -DHAVE_CONFIG_H -DNMAP_PLATFORM=\"aarch64-unknown-linux-gnu\" -DNMAPDATADIR=\"/nix/store/885x4inw6hqnxwmyzanp5cyh9gs9cdiq-nmap-aarch64-unknown-linux-gnu-7.94/share/nmap\" -D_FORTIFY_SOURCE=2 -g -O2 -Wall -fno-strict-aliasing TargetGroup.cc -o TargetGroup.o
aarch64-unknown-linux-gnu-gcc -O2 -Wall -Wextra -DLUA_COMPAT_5_3 -g -O2 -Wall -DLUA_USE_POSIX -DLUA_USE_DLOPEN -c -o linit.o linit.c
aarch64-unknown-linux-gnu-ar liblua.a lapi.o lcode.o lctype.o ldebug.o ldo.o ldump.o lfunc.o lgc.o llex.o lmem.o lobject.o lopcodes.o lparser.o lstate.o lstring.o ltable.o ltm.o lundump.o lvm.o lzio.o lauxlib.o lbaselib.o lcorolib.o ldblib.o liolib.o lmathlib.o loadlib.o loslib.o lstrlib.o ltablib.o lutf8lib.o linit.o
aarch64-unknown-linux-gnu-ar: libdeps specified more than once
make[1]: *** [Makefile:60: liblua.a] Error 1
make[1]: Leaving directory '/build/nmap-7.94/liblua'
make: *** [Makefile:166: build-lua] Error 2
make: *** Waiting for unfinished jobs.... |
uninsane
added a commit
to uninsane/nixpkgs
that referenced
this pull request
Jun 28, 2023
nmap was updated from 7.93 -> 7.94 in <NixOS#238960> as part of that update, upstream migrated from lua5.3 to lua5.4, see: <nmap/nmap@7d57e7d> nmap's configure script falls back to its vendored liblua if it can't find the expected lua version (silently). that means we lost all nix-specific lua patches that make things like cross compilation work. this patch brings the lua versions back in line to fix that regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Package bump and remove last traces of zenmap support which hasn't been enabled for a while.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)