nmap: lua5_3 -> lua5_4 #240440
Merged
nmap: lua5_3 -> lua5_4 #240440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmap was updated from 7.93 -> 7.94 in <NixOS#238960> as part of that update, upstream migrated from lua5.3 to lua5.4, see: <nmap/nmap@7d57e7d> nmap's configure script falls back to its vendored liblua if it can't find the expected lua version (silently). that means we lost all nix-specific lua patches that make things like cross compilation work. this patch brings the lua versions back in line to fix that regression.
uninsane
added
the
6.topic: cross-compilation
|
@ofborg build pkgsCross.aarch64-multiplatform.nmap |
|
Result of 20 packages built:
|
NickCao
approved these changes
Jun 29, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nmap was updated from 7.93 -> 7.94 in
#238960
as part of that update, upstream migrated from lua5.3 to lua5.4, see: nmap/nmap@7d57e7d
nmap's configure script falls back to its vendored liblua if it can't find the expected lua version (silently). that means we lost all nix-specific lua patches that make things like cross compilation work. this patch brings the lua versions back in line to fix that regression.
Description of changes
Things done
pkgsCross.aarch64-multiplatform.nmap)sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)