libgudev: 237 → 238

[jtojnar]

Description of changes

cc @flokli for umockdev changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[flokli]

Hooh, interesting bootstrapping problem :-D But LGTM 👍

[flokli]

Didn't check if it builds.

[Alanazane]

After Arch updated to 238 Steam is failing to launch for some users, this was found to not be a libgudev issue but a Steam one. Figured it might be worth noting here just in case Steam doesn't fix the issue before this is set to land.
However I was unable to reproduce the bug after rebuilding with this branch, so it may not effect users NixOS regardless :)

Steam issue for the bug here: ValveSoftware/steam-for-linux#9805

[jtojnar]

Reading the upstream issue, it is a clash between system and steam-runtime libgudev. Our steam-run does not appear to contain libgudev so I guess we are fine.

[trofi]

Bisect says commit eafa5c9 libgudev: 237 → 238 broke upower test:

$ nix build --no-link -f. -L upower
...
upower> Summary of Failures:
upower> 29/58 Tests.test_hidpp_touchpad                                  FAIL            0.49s   exit status 1
upower> 32/58 Tests.test_hidpp_touchpad_race                             FAIL            0.74s   exit status 1

[jtojnar]

Ugh, we noticed there were some flaky tests in #241586 (comment) but did not bump it because it required libgudev 238. I guess it is safe to bump now, opened #243217