nixos/soft-serve: init #242467
Merged
nixos/soft-serve: init #242467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
6 times, most recently
from
a76cf24
to
b89db2c
Compare
caarlos0
approved these changes
Jul 10, 2023
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2420 |
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
from
2861030
to
c3b204c
Compare
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
from
c3b204c
to
bfde5e2
Compare
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
from
28fad9e
to
4cb6f12
Compare
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
from
4cb6f12
to
441a155
Compare
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
from
441a155
to
dda88a3
Compare
|
Hi, how can we proceed with this? I think I have addressed all change requests and the branch still has no conflicts. Can this be merged? |
Janik-Haag
reviewed
Oct 20, 2023
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
from
dda88a3
to
ce64489
Compare
This adds bash to the PATH of soft-serve. This is required for the hooks to work, since they are implemented in bash.
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
from
ce64489
to
8bc1ba6
Compare
|
Result of 1 package blacklisted:
1 package built:
|
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
2 times, most recently
from
3197960
to
4275ac8
Compare
Janik-Haag
reviewed
Oct 21, 2023
Janik-Haag
reviewed
Oct 21, 2023
This adds a NixOS module for Soft Serve, a tasty, self-hostable Git server for the command line. The module has a test that checks some basic things like creating users, creating a repo and cloning it. Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
dadada
force-pushed
the
dev/dadada/init-nixos-soft-serve
branch
from
4275ac8
to
77f7b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds a NixOS module for Soft Serve, a tasty, self-hostable Git server for the command line.
The module has a test that checks some basic things like creating users, creating a repo and cloning it. Bash is required for running the hook scripts (e.g., on push), so I added it to the path of the wrapper.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)