Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.imgaug: remove #242752

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

bcdarwin
Copy link
Member

python310Packages.mask-rcnn: remove

Description of changes

Remove some obsolete broken/unbuildable packages (which also depend on insecure opencv3).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

In addition to being unmaintained, it has been broken in Nixpkgs for
some time due to library incompatibilities.
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time flies.
LGTM, thanks.

@NickCao NickCao merged commit 63b561d into NixOS:master Jul 11, 2023
19 checks passed
@bcdarwin bcdarwin deleted the remove-python3-imgaug branch July 11, 2023 14:17
@happysalada
Copy link
Contributor

unfortunately there are still quite a few packages that depends on imgaug.
Not sure what to do in that case.
https://github.com/PaddlePaddle/PaddleOCR/blob/b13f99607653c220ba94df2a8650edac086b0f37/requirements.txt
PaddleOCR is quite relevant in the ocr space unfortunately.
If you have ideas for workaround, I'd be happy to try them.

@bcdarwin
Copy link
Member Author

I don't see any way this can work with recent Nixpkgs unless someone patches imgaug to work with recent versions of its dependencies, but no-one has volunteered to maintain it upstream.

@natsukium
Copy link
Member

imgaug is too old, and we should stop using it.
It will never be updated again, as aleju/imgaug#824 shows.

We can ask upstream to stop using imgaug, or we can drop the library and package it with buildPythonApplication since PaddleOCR is also a CLI application.

@happysalada
Copy link
Contributor

I opened an issue upstream to ask them to drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants