Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.albumentations: init at 1.3.1 #242757

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

natsukium
Copy link
Member

Description of changes

Fast image augmentation library and an easy-to-use wrapper around other libraries. Documentation: https://albumentations.ai/docs/ Paper about the library: https://www.mdpi.com/2078-2489/11/2/125

https://github.com/albumentations-team/albumentations

This is a cutout of the discarded PR.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member

Note that imgaug will be an undefined attribute after #242752 is merged, so should be removed.

@natsukium
Copy link
Member Author

Good catch, I just made sure that imgaug is not used in other existing packages and forgot about this PR.
Thanks!

@bcdarwin
Copy link
Member

Results of nixpkgs-review on x86_64-NixOS:

8 packages built:
python310Packages.albumentations python310Packages.albumentations.dist python310Packages.qudida python310Packages.qudida.dist python311Packages.albumentations python311Packages.albumentations.dist python311Packages.qudida python311Packages.qudida.dist

Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1024

@SuperSandro2000 SuperSandro2000 merged commit 9cbcbd8 into NixOS:master Jul 20, 2023
22 checks passed
@natsukium natsukium deleted the albumentations/init branch July 21, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants