New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCaml Package Updates #24393
OCaml Package Updates #24393
Conversation
}; | ||
|
||
patches = [ ./camlp4-git.patch ./meta.patch ./srcdir.patch ]; | ||
patches = [ ./camlp4-git.patch ]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The srcdir
patch seems still needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me the environment in which this fails? It builds locally for me, and I'd like to know how to observe the build failure to avoid this in the future. (I've added srcdir.patch back in locally, and it'll be in a changed PR in a few minutes after I finish doing a clean rebase on master.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On darwin, I get the following trace:
building
make flags: SHELL=/nix/store/rafidkx85sv66c1q9iplq6zkjhs2136a-bash-4.4-p12/bin/bash
{ echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
cat /byteswap.in.h; \
} > byteswap.h-t
cat: /byteswap.in.h: No such file or directory
make: *** [Makefile:127: byteswap.h] Error 1
builder for ‘/nix/store/mgjnwki5lpknbi3c3fczm0fr5nmlj79j-ocaml-bitstring-2.1.0.drv’ failed with exit code 2
Wild guess: the issue does not show up on Linux since the byteswap.h
file is found in the libc.
You may remove the patch, if you prefer something like: makeFlags = "srcdir=.";
.
Fixes bug with modern zlib and large files
Fixes a bug with copying symlinks
@vbgl I'm fine with leaving the patch in there, I was just curious. The Travis Darwin builder failed for other reasons before it got there so I didn't know that was the issue. |
That just leaves |
Everything I'm concerned with has been merged, I'll leave appropriately masking the compiler on |
Nevermind, I'm clumsy and missed that |
aaand I was looking at a stale copy, we're actually good here, sorry about the noise |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)This is a batch update of OCaml packages. If you want I can split it up, but most of it is fairly straightforward version bumps/bugfixes.