Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf3: 21.12 -> 23.4 #244539

Merged
merged 2 commits into from Aug 5, 2023
Merged

protobuf3: 21.12 -> 23.4 #244539

merged 2 commits into from Aug 5, 2023

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jul 20, 2023

Description of changes

https://github.com/protocolbuffers/protobuf/releases/tag/v23.4

v22 is also not packaged, but since it hasn't been added so far I think we can leave a gap.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tobim tobim changed the title protobuf3_23: init at 3.23.4 protobuf3: 21.12 -> 23.4 Jul 21, 2023
@ofborg ofborg bot requested review from andersk and jonringer July 21, 2023 05:11
@tobim tobim marked this pull request as draft July 21, 2023 05:44
@tobim tobim changed the base branch from master to staging July 21, 2023 05:46
@tobim tobim marked this pull request as ready for review July 21, 2023 05:46
@marsam marsam merged commit c0f799f into NixOS:staging Aug 5, 2023
21 checks passed
@tobim tobim deleted the pkgs/protobuf3_23 branch August 9, 2023 16:35
@tobim tobim mentioned this pull request Aug 9, 2023
12 tasks
@tjni
Copy link
Contributor

tjni commented Aug 10, 2023

protobuf-c is broken and it looks like they haven't released a version that supports 22.x or 23.x yet. I did find protobuf-c/protobuf-c#673, which indicates support should be present in their next branch.

@NickCao, do you have a preference on what to do?

@NickCao
Copy link
Member

NickCao commented Aug 10, 2023

@NickCao, do you have a preference on what to do?

Let's bump to the version in next, protobufc is depended by a handful of important packages and we cannot leave it broken.

@tjni
Copy link
Contributor

tjni commented Aug 10, 2023

I opened #248306. Adding abseil-cpp to propagatedBuildInputs was indeed needed. I don't have the ability to test this on Linux; I could only test it on aarch64-darwin since I had already built all of the stuff on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants