-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protobufc: 1.4.1 -> unstable-2023-07-08 #248306
Conversation
|
@ofborg build protobuf protobuf.passthru.tests protobufc protobufc.passthru.tests |
I do not yet understand these failures on aarch64-linux and x86_64-linux. I initially thought it might be the change to move abseil-cpp to propagatedBuildInputs, but I cherry picked the protobuf + abseil updates by themselves onto master and was not able reproduce. So it's something else, but I don't have a real Linux machine with multiple cores to try building variants. Would anyone be able to help me take a look also? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed upstream changes, nothing affecting packaging.
And the build failure is on |
@ofborg build protobufc unbound ocserv fwupd |
Description of changes
I have only built this against the new protobuf in staging on my aarch64-darwin machine, since I had everything built already. I don't have the ability to test it on Linux at the moment.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)