-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up contributing documentation #245243
Merged
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
be26d79
doc/contributing: Remove unreferenced legacy diagram
infinisil d70091c
Create unified markdown files for contributing docs
infinisil b98abe5
README.md: Rough move to new contribution doc files
infinisil b7c5258
CONTRIBUTING.md: Rough move to new contribution doc files
infinisil 1e1cd39
doc/coding-conventions: Rough move to new contribution doc files
infinisil 74b17a5
doc/contributing-to-documentation: Rough move to new contribution doc…
infinisil 90bf25d
doc/quick-start: Rough move to new contribution doc files
infinisil f3a050a
doc/reviewing-contributions: Rough move to new contribution doc files
infinisil 86f14e4
doc/submitting-changes: Rough move to new contribution doc files
infinisil 129da60
doc/vulnerability-roundup: Rough move to new contribution doc files
infinisil 549ecbc
doc: Add empty development section
infinisil 3796808
CONTRIBUTING.md: Move opening issues section to Nixpkgs manual
infinisil 1a29060
CONTRIBUTING.md: Remove temporarily
infinisil 350eb69
Move CONTRIBUTING-new.md to CONTRIBUTING.md
infinisil 3d5fc07
CONTRIBUTING.md: Add intro
infinisil ecee8c3
CONTRIBUTING.md: Add overview
infinisil 44293fb
pkgs/README.md: Add overview
infinisil 9489e19
CONTRIBUTING.md: Move pull request template section to the bottom
infinisil dfe311b
CONTRIBUTING.md: Collect paragraphs into a new commit conventions sec…
infinisil 99c6942
CONTRIBUTING.md: Coding conventions -> code conventions
infinisil 67ae88c
CONTRIBUTING.md: Write a new section on how to propose a change
infinisil 5789cc3
CONTRIBUTING.md: Clean up "Making patches" section
infinisil aace54f
CONTRIBUTING.md: Move flow of changes section up
infinisil 7ab012c
CONTRIBUTING.md: Replace staging workflow diagram
infinisil 9cae397
CONTRIBUTING.md: Clean up and condense staging workflow section
infinisil b665608
CONTRIBUTING.md: Move release sections together
infinisil 3639a9e
CONTRIBUTING.md: Clean up releases section
infinisil 4e3064d
CONTRIBUTING.md: Minor formatting fixes
infinisil 2f345d0
CONTRIBUTING.md: Remove duplicated section
infinisil 2a99b5a
CONTRIBUTING.md: Move rebasing section up
infinisil 0bd8c9b
CONTRIBUTING.md: New section on which branch to use
infinisil 1665134
CONTRIBUTING.md: Minor fixes
infinisil b069d2d
CONTRIBUTING.md: Move sections around
infinisil e630780
pkgs/README.md: Minor header and link fixes
infinisil 553daae
doc/README.md: Cleanup
infinisil 15ca783
nixos/README.md: GitHub markdown fixes
infinisil d5148f2
maintainer/README.md: GitHub markdown fixes
infinisil aafc9ae
pkgs/README.md: Remove some mediocre duplicated sentences
infinisil b0f61e3
CODEOWNERS: Add myself to the newly added files
infinisil 237799a
CONTRIBUTING.md: Minor content updates based on reviews
infinisil 2ce1e0b
CONTRIBUTING.md: Typos and formatting
infinisil de5a39f
CONTRIBUTING.md: Move boot loader-specific sentence to pkgs/README.md
infinisil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works when rendered in through GitHub, but I think you meant
1.
,2.
,3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's intentional, I don't really mind either way, but that's an explicitly supported GitHub Markdown feature (and I think effectively all markdown flavors support this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok good to know. I was just confused when reading through the source code.