Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuclear: 0.6.6 -> 0.6.27 #245680

Merged
merged 1 commit into from
Aug 10, 2023
Merged

nuclear: 0.6.6 -> 0.6.27 #245680

merged 1 commit into from
Aug 10, 2023

Conversation

NotAShelf
Copy link
Member

Description of changes
  • Bumped nuclear package version from 0.6.6 to 0.6.27
  • Cleaned package structure
  • Added NotAShelf to maintainers
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/applications/audio/nuclear/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/nuclear/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/nuclear/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/nuclear/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/nuclear/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/nuclear/default.nix Outdated Show resolved Hide resolved
@NotAShelf
Copy link
Member Author

Should be good now.

Copy link
Member

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple other changes oops, with these it builds and runs properly

pkgs/applications/audio/nuclear/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/nuclear/default.nix Outdated Show resolved Hide resolved
@NotAShelf
Copy link
Member Author

Alright, pushed the changes. Afraid I do not have the bandwidth to build the package right now, so it's worth nothing it's untested on my behalf.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/where-did-you-get-stuck-in-the-nix-ecosystem-tell-me-your-story/31415/18

@fpletz fpletz merged commit 353308d into NixOS:master Aug 10, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants