lib.types.string: Deprecation error instead of warning #247848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type has given a warning on use since [4 years ago](03392cd336b128a1639c648baf0f6c1a1271e0d2), I think it's safe to move the deprecation to the next stage: An error instead of a warning.
fpletz
approved these changes
Aug 8, 2023
roberth
approved these changes
Aug 8, 2023
|
After this PR is merged, github actions of building NixOS manual fail because of existing usage of |
jian-lin
added a commit
to linj-fork/nixpkgs
that referenced
this pull request
Aug 8, 2023
It is an error[1] now. [1]: NixOS#247848
12 tasks
calbrecht
added a commit
to calbrecht/home-manager
that referenced
this pull request
Aug 8, 2023
Since the merge of NixOS/nixpkgs#247848
6 tasks
ncfavier
pushed a commit
to nix-community/home-manager
that referenced
this pull request
Aug 8, 2023
Since the merge of NixOS/nixpkgs#247848
|
This was a mistake, see the revert in #248278 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-build-errors-out-nixos-unstable/31642/5 |
LunNova
added a commit
to LunNova/nixos-configs
that referenced
this pull request
Aug 13, 2023
Broke due to NixOS/nixpkgs#247848 making it an error, was no deprecation warning
Luflosi
pushed a commit
to Luflosi/home-manager
that referenced
this pull request
Aug 15, 2023
Luflosi
pushed a commit
to Luflosi/home-manager
that referenced
this pull request
Aug 15, 2023
ncfavier
pushed a commit
to ncfavier/home-manager
that referenced
this pull request
Aug 15, 2023
Since the merge of NixOS/nixpkgs#247848 (cherry picked from commit 7b8d43f)
ncfavier
added a commit
to nix-community/home-manager
that referenced
this pull request
Aug 15, 2023
Since the merge of NixOS/nixpkgs#247848 (cherry picked from commit 7b8d43f) Co-authored-by: Christian Albrecht <christian.albrecht@mayflower.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The type has given a warning on use since 4 years ago, I think it's safe to move the deprecation to the next stage: An error instead of a warning.
Before:
After:
Things done