ocaml-protoc-plugin: init at 4.3.1

[GirardR1006]

Description of changes

Adding ocaml-protoc-plugin, an Ocaml library to convert Google protobuf format into Ocaml types.

Project homepage: https://github.com/issuu/ocaml-protoc-plugin

I am not the original author, but I find this tool convenient enough to be added into nixpkgs. I will gladly be added as a maintainer for this package.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[symphorien]

Thanks for you PR. I left a few comments mostly about style/metadata, but the package itself seems to build fine :)

[symphorien]

Also please add yourself to the list in one commit, and then modify the package in one other. This is to ensure we can revert the commit affecting the package without breaking evaluation even if you add yourself as maintainer to other packages in the meantime.

[drupol]

Hi !

Thanks for your contribution.

I've left some comments, left me know if this is clear enough.

[drupol]

Moving this PR in draft until the feedback has been addressed, feel free to remove it from draft when it's done, so we can see it again appearing in our list of PRs to review. Thanks!

[GirardR1006]

Moving this PR in draft until the feedback has been addressed, feel free to remove it from draft when it's done, so we can see it again appearing in our list of PRs to review. Thanks!

Thanks for that, I'll address your feedbacks during the week :)

[drupol]

Can you please ensure that your PR only contains 2 commits?

• 1 commit for adding you in the maintainers list: maintainers: add GirardR1006
• 1 commit for the rest: ocaml-protoc-plugin: init at 4.3.1

[GirardR1006]

Can you please ensure that your PR only contains 2 commits?

* 1 commit for adding you in the maintainers list: `maintainers: add GirardR1006`

* 1 commit for the rest: `ocaml-protoc-plugin: init at 4.3.1`

That should be it. Sorry for the force pushes, I believe they are making the review progress less trackable. Taking any advices on how to do that better for future contributions :)

[drupol]

No worries for the force-pushed, it's mandatory here, and it's not considered as a bad practice as long as you stay in your branch, hopefully.

At the moment, the CONTRIBUTING.md file is being rewritten, but you can already find some leads in there.

For the rest, the commiters/maintainers are here to review and provide feedback.

Feel free to ask anything, we'll be there to help.

[drupol]

One last minor thing and it's good to go for me.

[drupol]

LGTM now, thanks for implementing all the change requests!