kubo: remove openssl from the build #248441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed openssl support from go-libp2p and thus Kubo: - libp2p/go-libp2p#1952 Now we exclusively on the options provided by the golang std librairy. The openssl tag is now a noop, having it does not cause any harm except making nixos install openssl for no reason while using kubo but I guess many systems already build openssl but might as well not have it.
Yes, it will. Thank you very much for your contribution and insight in the upstream project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We removed openssl support from go-libp2p and thus Kubo:
Now we exclusively on the options provided by the golang std librairy.
The openssl tag is now a noop, having it does not cause any harm except
making nixos install openssl for no reason while using kubo but I guess
many systems already build openssl but might as well not have it.
Things done
I do not have nix installed on my system, I caught this while investigating ipfs/kubo#10056, I would hope such small change would be testable by CI.
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)