Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs manual: doc python: render manual notes as admonitions #250548

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

alejandrosame
Copy link
Contributor

Description of changes

Make notes stand out by rendering them as admonitions.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alejandrosame alejandrosame added 6.topic: documentation Meta-discussion about documentation and its workflow and removed 8.has: documentation labels Aug 21, 2023
@alejandrosame alejandrosame self-assigned this Aug 21, 2023
@alejandrosame alejandrosame requested review from adisbladis, Artturin and mweinelt and removed request for mweinelt, FRidh, adisbladis and Artturin August 21, 2023 14:14
@mweinelt mweinelt merged commit 75bf555 into NixOS:master Aug 21, 2023
5 of 6 checks passed
@alejandrosame alejandrosame deleted the doc-python-admonitions branch August 21, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants