Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipscan: fix and update broken package #252363

Merged
merged 4 commits into from
Aug 30, 2023
Merged

ipscan: fix and update broken package #252363

merged 4 commits into from
Aug 30, 2023

Conversation

totoroot
Copy link
Contributor

@totoroot totoroot commented Aug 30, 2023

Description of changes

I found the issue and fixed ipscan.

It has been broken in nixpkgs for over 3 years. I figured out that the commit that broke the package was e191332.
In the meantime there have been a couple version updates for this package, but all this time it was broken. See more in these PR threads:

Also:

  • Updated from 3.9.0 to 3.9.1
  • Added myself as a maintainer
  • Added the meta attribute downloadPage
  • Set the meta attribute description to the repo's description
  • Added an alias for the package/project's common name

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank wegank merged commit 81ece9e into NixOS:master Aug 30, 2023
26 of 27 checks passed
@totoroot totoroot deleted the fix-ipscan branch August 31, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants