Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chatall: init at 1.54.83 #254797

Closed
wants to merge 1 commit into from
Closed

chatall: init at 1.54.83 #254797

wants to merge 1 commit into from

Conversation

paveloom
Copy link
Member

Description of changes

https://github.com/sunner/ChatALL

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@paveloom paveloom force-pushed the chatall branch 2 times, most recently from 9e00392 to a1821b7 Compare September 13, 2023 10:14
@paveloom paveloom changed the title chatall: init at 1.42.68 chatall: init at 1.42.69 Sep 13, 2023
@paveloom paveloom changed the title chatall: init at 1.42.69 chatall: init at 1.42.70 Sep 18, 2023
@paveloom paveloom changed the title chatall: init at 1.42.70 chatall: init at 1.48.71 Sep 18, 2023
@paveloom paveloom changed the title chatall: init at 1.48.71 chatall: init at 1.48.72 Sep 29, 2023
@paveloom paveloom changed the title chatall: init at 1.48.72 chatall: init at 1.50.73 Oct 1, 2023
@paveloom paveloom changed the title chatall: init at 1.50.73 chatall: init at 1.50.74 Oct 19, 2023
@paveloom paveloom force-pushed the chatall branch 2 times, most recently from 66cea37 to 29e43e2 Compare October 21, 2023 21:03
@paveloom paveloom changed the title chatall: init at 1.50.74 chatall: init at 1.50.75 Oct 21, 2023
@paveloom paveloom force-pushed the chatall branch 2 times, most recently from 013429c to e80ea8b Compare October 22, 2023 08:30
@paveloom paveloom changed the title chatall: init at 1.50.75 chatall: init at 1.51.76 Oct 22, 2023
@paveloom paveloom changed the title chatall: init at 1.51.76 chatall: init at 1.51.77 Oct 23, 2023
@paveloom paveloom changed the title chatall: init at 1.51.77 chatall: init at 1.51.78 Oct 30, 2023
@paveloom paveloom changed the title chatall: init at 1.51.78 chatall: init at 1.51.79 Nov 6, 2023
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package builds and launches.
It outputs update-electron-app config looks good; aborting updates since app is in development mode, but I don't know whether the app being in "development mode" is a problem for other functionality (disabling the auto-updater is good).

pkgs/by-name/ch/chatall/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ch/chatall/package.nix Show resolved Hide resolved
pkgs/by-name/ch/chatall/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ch/chatall/package.nix Outdated Show resolved Hide resolved
@paveloom
Copy link
Member Author

paveloom commented Nov 6, 2023

Forced it to think it's packaged and in production (similar to how it's done in youtube-music), so the message is gone now.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and launches successfully on x86_64-linux (when cherry-picked onto current master).

I'm surprised the "Help" menu is empty though. Is that expected for this program?

New output is Electron's autoUpdater does not support the 'linux' platform, which is good (for now).

@paveloom
Copy link
Member Author

paveloom commented Nov 7, 2023

I'm surprised the "Help" menu is empty though. Is that expected for this program?

I don't know the reasons why it's like that, but I just checked their AppImage, and it's the same there.

@paveloom
Copy link
Member Author

Seems like one has to use absolute paths in prePatch/postPatch since those are passed to the fetchNpmDeps function and the nativeBuildInputs are not:

, npmDeps ? fetchNpmDeps {
inherit forceGitDeps forceEmptyCache src srcs sourceRoot prePatch patches postPatch;
name = "${name}-npm-deps";
hash = npmDepsHash;
}

@paveloom paveloom force-pushed the chatall branch 2 times, most recently from 1217897 to ead5b23 Compare November 28, 2023 07:48
@paveloom paveloom changed the title chatall: init at 1.51.79 chatall: init at 1.53.81 Nov 28, 2023
@paveloom
Copy link
Member Author

If you run into errors containing Skia shader compilation error, run rm -rf ~/.config/chatall/GPUCache.

@paveloom paveloom changed the title chatall: init at 1.53.81 chatall: init at 1.54.82 Dec 3, 2023
@paveloom paveloom changed the title chatall: init at 1.54.82 chatall: init at 1.54.83 Dec 17, 2023
@paveloom paveloom closed this Jan 14, 2024
@paveloom paveloom deleted the chatall branch January 14, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants