-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chatall: init at 1.54.83 #254797
chatall: init at 1.54.83 #254797
Conversation
9e00392
to
a1821b7
Compare
66cea37
to
29e43e2
Compare
013429c
to
e80ea8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package builds and launches.
It outputs update-electron-app config looks good; aborting updates since app is in development mode
, but I don't know whether the app being in "development mode" is a problem for other functionality (disabling the auto-updater is good).
Forced it to think it's packaged and in production (similar to how it's done in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and launches successfully on x86_64-linux (when cherry-picked onto current master).
I'm surprised the "Help" menu is empty though. Is that expected for this program?
New output is Electron's autoUpdater does not support the 'linux' platform
, which is good (for now).
I don't know the reasons why it's like that, but I just checked their AppImage, and it's the same there. |
Seems like one has to use absolute paths in nixpkgs/pkgs/build-support/node/build-npm-package/default.nix Lines 47 to 51 in a694f3f
|
1217897
to
ead5b23
Compare
If you run into errors containing |
Description of changes
https://github.com/sunner/ChatALL
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)