python3.pkgs.astropy: 5.2.1 -> 5.3.3 & more #255124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
This is not ready yet, I've had good progress with upstream at astropy/astropy#15316 . Marking as draft, will revisit this tomorrow. |
Upstream a better version of the premissions.patch file, and explain it better in a comment.
Use NIX_CFLAGS_COMPILE = "-O2", due to upstream issue. cd "$out" to avoid circular import issue (discuessed downstream at at NixOS#255262).
Add some informatory comments, add doronbehar as maintainers, use `rec` instead of `let ... in`, add `pythonImportsCheck` and `pytestCheckHook`, use `cd $out` to handle issue NixOS#255262
doronbehar
changed the title
doronbehar
force-pushed
the
pkg/astropy
branch
from
899b1c3
to
55b52d2
Compare
13 tasks
|
Result of 8 packages marked as broken and skipped:
10 packages failed to build:
54 packages built:
|
|
Thanks for the review! I marked all of these packages as broken. Will merge when CI is green. |
doronbehar
force-pushed
the
pkg/astropy
branch
from
0c6afc4
to
bb63d64
Compare
|
For the record, these packages were broken on hydra much before this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)