Move Nimble out of Nim compiler wrapper #258093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Sep 29, 2023
|
Please rename commits to comply with CONTRIBUTING.md. |
Please be more specific so I don't have to fix the messages twice. |
|
Hi, this broke master and causes eval errors on ofborg: https://gist.github.com/GrahamcOfBorg/7a33204709bf948180670867a9e22e02. I will push a new PR to fix it. |
lf-
added a commit
to lf-/nixpkgs
that referenced
this pull request
Oct 2, 2023
nimble-unwrapped was breaking ofborg. :( By the looks of it nimble-unwrapped was removed but the references in all-packages.nix and in the callPackage invocation were not removed. So remove them. Proximal cause: NixOS#258093 https://gist.github.com/GrahamcOfBorg/7a33204709bf948180670867a9e22e02
alyssais
pushed a commit
that referenced
this pull request
Oct 2, 2023
nimble-unwrapped was breaking ofborg. :( By the looks of it nimble-unwrapped was removed but the references in all-packages.nix and in the callPackage invocation were not removed. So remove them. Proximal cause: #258093 https://gist.github.com/GrahamcOfBorg/7a33204709bf948180670867a9e22e02
nikstur
pushed a commit
to nikstur/nixpkgs
that referenced
this pull request
Oct 16, 2023
nimble-unwrapped was breaking ofborg. :( By the looks of it nimble-unwrapped was removed but the references in all-packages.nix and in the callPackage invocation were not removed. So remove them. Proximal cause: NixOS#258093 https://gist.github.com/GrahamcOfBorg/7a33204709bf948180670867a9e22e02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Nimble doesn't need to be bundled with the Nim compiler and shouldn't be tied to a specific Nim compiler.
Package the alternate package tool atlas.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)