nixos/knot: compatibility with 23.05 config #258361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still, the warning... maybe using
|
vcunat
force-pushed
the
p/knot-nixConfig
branch
from
9ad18e4
to
526dfca
Compare
- run conf-check iff keyFiles == [] (like in 23.05; this was my bug) - support extraConfig + keyFiles - but warning will still be shown if extraConfig is used, and it might be slightly confusing
vcunat
force-pushed
the
p/knot-nixConfig
branch
from
526dfca
to
6b66e2f
Compare
|
I believe this is an improvement, so let me merge now even if it's unclear whether some further improvements should be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #81460
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)