Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ft2-clone: 1.69 -> 1.71 #259155

Merged
merged 1 commit into from
Oct 5, 2023
Merged

ft2-clone: 1.69 -> 1.71 #259155

merged 1 commit into from
Oct 5, 2023

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Oct 5, 2023 •
edited
Loading

Description of changes

Drops the patches that have been integrated upstream

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fgaz fgaz requested a review from OPNA2608 October 5, 2023 09:36
@OPNA2608
Copy link
Contributor

OPNA2608 commented Oct 5, 2023

Don't have access to my Darwin nor my usual Linux system for awhile. I can test on aarch64-linux in afew hours, will see if Darwin OfBorg is happy with it at that point.

@OPNA2608
Copy link
Contributor

OPNA2608 commented Oct 5, 2023 •
edited
Loading

GitHub on mobile doesn't let me put down a comment at a code line, but maybe move the expression from mkDerivation rec { to mkDerivation (finalAttrs: { style while you're changing things?

@fgaz
Copy link
Member Author

fgaz commented Oct 5, 2023

I plan to change it treewide (on the packages I maintain) soon, so I didn't do it in this pr since I'm not touching that line

@cafkafk
Copy link
Member

cafkafk commented Oct 5, 2023

Result of nixpkgs-review pr 259155 run on x86_64-linux 1

1 package built:
  • ft2-clone

cafkafk
cafkafk approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-10-05_12-09

OPNA2608
OPNA2608 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't run nixpkgs-review on current hardware. Builds & works on aarch64-linux. Darwin CI is also happy, so LGTM. 🙂

@fgaz fgaz merged commit bb5e76b into NixOS:master Oct 5, 2023
34 checks passed
@fgaz fgaz deleted the ft2/1.71 branch October 5, 2023 16:02
@fgaz fgaz mentioned this pull request Oct 5, 2023
Closed
@JoNilsson
Copy link

This is awesome!

@fgaz
Copy link
Member Author

fgaz commented Oct 5, 2023

@JoNilsson you might be interested in #81815 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 approved these changes

@cafkafk cafkafk cafkafk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fgaz @OPNA2608 @cafkafk @JoNilsson @delroth