-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qgis: Enable mapserver #259303
qgis: Enable mapserver #259303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgamari , thank you very much for contribution. I am interested in server build too, but it would be much better if we build separate server package. Server package should be built for LTR version as well and nixos test is should be included with PR.
I am happy to help you if you are interested in enhancing your PR.
That's a good question, I am not sure. Maybe separate |
I suspect that a separate output is really the only viable option. From a cursory inspection of QGIS's build system, it doesn't appear to be possible to build the core library and then later (in a separate tree) link the desktop application/server against that library. Consequently, I think the only option is to build all three and then carefully separate them into separate outputs. However, I'm not sure I feel confident enough in my knowledge of QGIS's internal structure to be able to safely do this. |
b67e0f4
to
604bdc1
Compare
I have looked more closely at the output of the derivation and have concluded that I don't feel comfortable performing an output split. There are simply too many files which I, as a relative casual user of QGIS, cannot easily determine the usage of (e.g. should I think either we should merge this as-is or we decide not to merge at all. The risk (and maintainability challenge) of performing an output split strikes me as not justified by the very minor size increase that enabling the server component. I have, however, integrated @sikmir's suggestion and propagated the change to the LTR derivation. |
604bdc1
to
6b4fd5d
Compare
What about following QGIS Debain packaging and put everything what they in |
I suppose you mean |
Here we enable QGis's internal [tileserver] implementation. I have found this useful and the size of the binary itself is negligible (around 300kB). [tileserver]: https://docs.qgis.org/3.28/en/docs/server_manual
6b4fd5d
to
a5e01d9
Compare
I think the main reason is to keep QGIS default package size down. I guess that vast majority of QGIS package users are using only desktop interface. Also, I think the list of files belonging to server is not changing very often so the maintenance cost wouldn't be very high. |
Yes, sorry. I fixed that in my comment. |
This PR is now replaced by #267301 |
Description of changes
Here we enable QGis's internal tileserver implementation. I have found this useful and the size of the binary itself is negligible (around 300kB).
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)