Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgis: add server support #267301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

qgis: add server support #267301

wants to merge 1 commit into from

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Nov 13, 2023

Description of changes

Add QGIS server support for QGIS and QGIS-LTR.

This PR is co-authored by @bgamari in #259303 .

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@imincik imincik marked this pull request as draft November 13, 2023 21:10
@imincik imincik self-assigned this Nov 13, 2023
@imincik imincik mentioned this pull request Nov 13, 2023
12 tasks
@ofborg ofborg bot requested review from willcohen, nh2, lsix and sikmir November 13, 2023 23:28
@imincik imincik force-pushed the qgis-server branch 5 times, most recently from 2369f2a to 1ad1fda Compare November 15, 2023 04:24
@imincik imincik changed the title qgis: build with server support qgis: add server support Nov 15, 2023
@imincik imincik requested a review from bgamari November 15, 2023 04:27
@imincik
Copy link
Contributor Author

imincik commented Nov 15, 2023

@ofborg build qgis qgis-ltr

@imincik imincik marked this pull request as ready for review November 15, 2023 04:54
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team-11-17-dec-2023/37035/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/2

@nialov
Copy link
Contributor

nialov commented Jan 14, 2024

Result of nixpkgs-review pr 267301 run on x86_64-linux 1

2 packages failed to build:
  • qgis
  • qgis-ltr

@nialov
Copy link
Contributor

nialov commented Jan 14, 2024

Getting a build error for PDAL which is a bit unexpected I guess?

error: builder for '/nix/store/34r5sjavrbr7pjhj3a176zk96pizk999-pdal-2.5.6.drv' failed with exit code 2;
       last 25 log lines:
       > [ 36%] Building CXX object CMakeFiles/pdal_base.dir/pdal/StageExtensions.cpp.o
       > [ 36%] Building CXX object CMakeFiles/pdal_base.dir/pdal/StageFactory.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/Streamable.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/SubcommandKernel.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/Writer.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/XMLSchema.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/compression/DeflateCompression.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/compression/LazPerfVlrCompression.cpp.o
       > /build/source/pdal/XMLSchema.cpp: In member function 'bool pdal::XMLSchema::validate(xmlDocPtr, const std::string&)':
       > /build/source/pdal/XMLSchema.cpp:257:9: error: invalid conversion from 'void (*)(void*, xmlErrorPtr)' {aka 'void (*)(void*, _xmlError*)'} to 'xmlStructuredErrorFunc' {aka 'void (*)(void*, const _xmlError*)'} [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-fpermissive-fpermissive8;;]
       >   257 |         &SchemaParserStructuredErrorHandler, m_global_context);
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       >       |         |
       >       |         void (*)(void*, xmlErrorPtr) {aka void (*)(void*, _xmlError*)}
       > In file included from /build/source/pdal/XMLSchema.hpp:50,
       >                  from /build/source/pdal/XMLSchema.cpp:34:
       > /nix/store/iqjsxkcdnvvz1bfpq960ygicc5clz9hv-libxml2-2.12.3-unstable-2023-12-14-dev/include/libxml2/libxml/xmlschemas.h:156:65: note:   initializing argument 2 of 'void xmlSchemaSetParserStructuredErrors(xmlSchemaParserCtxtPtr, xmlStructuredErrorFunc, void*)'
       >   156 |                                          xmlStructuredErrorFunc serror,
       >       |                                          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
       > [ 38%] Building CXX object CMakeFiles/pdal_base.dir/pdal/compression/ZstdCompression.cpp.o
       > [ 38%] Building CXX object CMakeFiles/pdal_base.dir/pdal/pdal_config.cpp.o
       > make[2]: *** [CMakeFiles/pdal_base.dir/build.make:2386: CMakeFiles/pdal_base.dir/pdal/XMLSchema.cpp.o] Error 1
       > make[2]: *** Waiting for unfinished jobs....
       > make[1]: *** [CMakeFiles/Makefile2:739: CMakeFiles/pdal_base.dir/all] Error 2
       > make: *** [Makefile:166: all] Error 2
       For full logs, run 'nix log /nix/store/34r5sjavrbr7pjhj3a176zk96pizk999-pdal-2.5.6.drv'.
error: 1 dependencies of derivation '/nix/store/219shfbf0y2sljyfi97bs9r1ifa02f3p-grass-8.3.1.drv' failed to build
error: 2 dependencies of derivation '/nix/store/qsc6v3k5r3af0pjh3wq3br11n9l987hn-qgis-ltr-unwrapped-3.28.14.drv' failed to build
error: 2 dependencies of derivation '/nix/store/3v0hbpdff85d575vb8jhpnmd2bda2lim-qgis-unwrapped-3.34.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/f9zjmknpw2lgrcc9d9p553nfyww1lgvg-qgis-3.28.14.drv' failed to build
error: 1 dependencies of derivation '/nix/store/l20aw7b6zh7yik6wqhrrzmjfwcjbq2z6-qgis-3.34.2.drv' failed to build
error: 2 dependencies of derivation '/nix/store/iwzfrx7r1gl8gsi5k4z3blb7mnp99q0k-review-shell.drv' failed to build

Co-authored-by: Ben Gamari <ben@smart-cactus.org>
@imincik
Copy link
Contributor Author

imincik commented Jan 15, 2024

@nialov , thank you very much for reviewing

Getting a build error for PDAL which is a bit unexpected I guess?

I think, the reason why pdal build was failing at the moment of your review was because of latest staging-next containing some breaking libxml change which broke PDAL .

staging-next branch was merged 3 days ago and our PDAL fix was merged yesterday.

@imincik
Copy link
Contributor Author

imincik commented Jan 15, 2024

Result of nixpkgs-review pr 267301 run on x86_64-linux 1

2 packages failed to build:
  • qgis
  • qgis-ltr

qgis fails during `sip-build (see: #281100) which a new issue.

@ofborg ofborg bot requested review from das-g, r-burns and nialov January 15, 2024 12:55
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants