Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.deep_merge: remove #259944

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

natsukium
Copy link
Member

Description of changes

part of #245383

deep_merge was introduced as a dependency for checkov, but it has not been maintained for over 5 years and checkov has removed it in this PR.
bridgecrewio/checkov#5605

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

It is no longer maintained and is not needed for other packages.
@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 259944 run on x86_64-linux 1

2 packages built:
  • checkov
  • checkov.dist

@NickCao NickCao merged commit 2c53f43 into NixOS:master Oct 9, 2023
27 checks passed
@natsukium natsukium deleted the deep_merge/drop branch October 9, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants