Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.pillow: 10.0.1 -> 10.1.0 #261282

Merged
merged 1 commit into from
Oct 21, 2023
Merged

python310Packages.pillow: 10.0.1 -> 10.1.0 #261282

merged 1 commit into from
Oct 21, 2023

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Oct 15, 2023 •
edited

Description of changes

Update Pillow.
Changelog: https://github.com/python-pillow/Pillow/releases/tag/10.1.0

cc @cillianderoiste @prikhi

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@GaetanLepage GaetanLepage mentioned this pull request Oct 15, 2023
Closed
12 tasks
@wegank
Copy link
Member

wegank commented Oct 17, 2023

Should be 10.0.1 -> 10.1.0 in the commit message.

@GaetanLepage GaetanLepage changed the title python310Packages.pillow: 10.0.0 -> 10.1.0 python310Packages.pillow: 10.0.1 -> 10.1.0 Oct 17, 2023
@GaetanLepage
Copy link
Contributor Author

Should be 10.0.1 -> 10.1.0 in the commit message.

Fixed !

@mweinelt
Copy link
Member

Should reference the changelog in the commit message.

@GaetanLepage
Copy link
Contributor Author

Should reference the changelog in the commit message.

Done !

@mweinelt mweinelt merged commit b15687d into NixOS:staging Oct 21, 2023
4 of 5 checks passed
@GaetanLepage GaetanLepage deleted the pillow3 branch October 21, 2023 18:44
@vcunat
Copy link
Member

vcunat commented Nov 3, 2023

python3Packages.imageio got broken by this (consequently about a hundred builds on Hydra), and upstream apparently doesn't have a working fix yet (syntax errors in tests get thrown): imageio/imageio#1045

/cc maintainer: @Luflosi

@mweinelt
Copy link
Member

mweinelt commented Nov 3, 2023

Then we should revert this update for now.

mweinelt added a commit that referenced this pull request Nov 3, 2023
@mweinelt
Revert "python310Packages.pillow: 10.0.1 -> 10.1.0"
f73439f 
This reverts commit e47c4fd.

This release contained breaking changes and downstream consumers like
imageio have yet to provide fixes for that.

That is unlikely to happen in time for NixOS 23.11.

cc #261282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prikhi prikhi Awaiting requested review from prikhi

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@wegank wegank Awaiting requested review from wegank

@NickCao NickCao Awaiting requested review from NickCao

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GaetanLepage @wegank @mweinelt @vcunat