nixos-rebuild: fix --install-bootloader flag with systemd-run #262724

thiagokokada · 2023-10-22T11:21:56Z

Description of changes

With #258571 nixos-rebuild --install-bootloader flag is broken because we don't preserve the NIXOS_INSTALL_BOOTLOADER flag.

This PR fixes this issue.

Things done

thiagokokada · 2023-10-22T11:22:21Z

CC @roberth.

thiagokokada · 2023-10-22T11:23:26Z

Before this PR:

$ sudo nixos-rebuild switch --install-bootloader
building the system configuration...
activating the configuration...
setting up /etc...
reloading user units for thiagoko...
setting up tmpfiles
reloading the following units: dbus-broker.service
restarting the following units: polkit.service
the following new units were started: libvirtd.service

After

$ sudo nixos-rebuild switch --install-bootloader
Copied "/nix/store/1zmmnm0r0bdga398rl7fc7s4hkyqxjk4-systemd-254.3/lib/systemd/boot/efi/systemd-bootx64.efi" to "/boot/EFI/systemd/systemd-bootx64.efi".
Copied "/nix/store/1zmmnm0r0bdga398rl7fc7s4hkyqxjk4-systemd-254.3/lib/systemd/boot/efi/systemd-bootx64.efi" to "/boot/EFI/BOOT/BOOTX64.EFI".
⚠️ Mount point '/boot' which backs the random seed file is world accessible, which is a security hole! ⚠️
⚠️ Random seed file '/boot/loader/random-seed' is world accessible, which is a security hole! ⚠️
Random seed file /boot/loader/random-seed successfully refreshed (32 bytes).
Created EFI boot entry "Linux Boot Manager".
activating the configuration...
setting up /etc...
reloading user units for thiagoko...
setting up tmpfiles
reloading the following units: dbus-broker.service
restarting the following units: polkit.service

arianvp · 2023-10-22T12:12:34Z

There should definitely be a nixos test to test this regression and we should add it to the tested job to catch such regressions in the future

thiagokokada · 2023-10-22T20:20:34Z

There should definitely be a nixos test to test this regression and we should add it to the tested job to catch such regressions in the future

I added it. Not sure if I did everything correctly with the tested job, can you double check?

roberth

Answering your question, and maybe the question of whoever needs this test later and expects the bootloader to be tested.

I don't want to block this, so if you apply the suggestions, that's good enough. Though ideally we make the test a bit more complete.

nixos/tests/nixos-rebuild-install-bootloader.nix

…combined

Depends on GRUB2/BIOS.

thiagokokada · 2023-10-23T11:41:10Z

Hope the tests still works in OfBorg, because I can't run it locally anymore for some reason (it is trying to build attr and acl and it is failing to download them from the mirrors).

I tried to add the libarchive (the dependency that is calling them) to the system.extraDependencies and even them it fails to work.

roberth · 2023-10-23T11:44:58Z

@ofborg test nixos-rebuild-install-bootloader

mweinelt · 2023-10-23T21:30:11Z

I think this change broke the tested set evaluation.

{UNKNOWN}: aggregate job ‘tested’ failed with the error: nixos.tests.nixos-rebuild-specialisations.x86_64-linux: does not exist at /nix/store/2cdksj9bxidws5ykb9v4pf8bghf5855j-hydra-perl-deps/lib/perl5/site_perl/5.36.0/Catalyst/Model/DBIC/Schema.pm line 526

mweinelt · 2023-10-23T21:32:27Z

nixos/tests/all-tests.nix

@@ -569,7 +569,8 @@ in {
  nix-serve-ssh = handleTest ./nix-serve-ssh.nix {};
  nixops = handleTest ./nixops/default.nix {};
  nixos-generate-config = handleTest ./nixos-generate-config.nix {};
-  nixos-rebuild-specialisations = handleTest ./nixos-rebuild-specialisations.nix {};
+  nixos-rebuild-install-bootloader = handleTestOn ["x86_64-linux"] ./nixos-rebuild-install-bootloader.nix {};
+  nixos-rebuild-specialisations = handleTest ["x86_64-linux"] ./nixos-rebuild-specialisations.nix {};


This should have been handleTestOn.

vcunat · 2023-10-24T07:50:00Z

The test can't build on Hydra. It exceeds the 3 GiB output limit. https://hydra.nixos.org/build/239312800

You know... perhaps it would be better to first let tests build for some time before making them channel blockers?

... at least until it's fixed. /cc PR #262724 again.

vcunat · 2023-10-24T07:57:33Z

Also, don't add channel blockers without maintainers:

$ nix eval -f. nixosTests.nixos-rebuild-specialisations.meta.maintainers
[ ]

vcunat · 2023-10-24T08:15:30Z

system.includeBuildDependencies = true; is the culprit of the huge image, apparently.

trofi · 2023-10-24T08:34:57Z

Looks like the real culprit is missing dependencies to rebuild initrd from within a VM (if we flip back to system.includeBuildDependencies = false;):

$ nix build --no-link -f. nixosTests.nixos-rebuild-install-bootloader -L

``` vm-test-run-nixos-rebuild-install-bootloader> machine # building '/nix/store/48kwl0adwbwlzw7x261v7w846pq48m3v-users-groups.json.drv'... vm-test-run-nixos-rebuild-install-bootloader> machine # Checking that Nix store paths of all wrapped programs exist... OK vm-test-run-nixos-rebuild-install-bootloader> machine # building '/nix/store/x30m3rvz7j39imcm6i25mf444kiavlbp-acl-2.3.1.tar.gz.drv'... vm-test-run-nixos-rebuild-install-bootloader> machine # building '/nix/store/hbd9bkhy0x7qfnl8p85793hh45yzdzsy-attr-2.5.1.tar.gz.drv'... vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6); retrying in 311 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/attr/attr-2.5.1.tar.gz': Couldn't resolve host name (6); retrying in 301 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6); retrying in 550 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/attr/attr-2.5.1.tar.gz': Couldn't resolve host name (6); retrying in 540 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6); retrying in 1250 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/attr/attr-2.5.1.tar.gz': Couldn't resolve host name (6); retrying in 1090 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6); retrying in 2201 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/attr/attr-2.5.1.tar.gz': Couldn't resolve host name (6); retrying in 2341 ms vm-test-run-nixos-rebuild-install-bootloader> machine # error: vm-test-run-nixos-rebuild-install-bootloader> machine # … writing file '/nix/store/y3yiminrckvhf35fh9q42vjwi0npznji-acl-2.3.1.tar.gz' vm-test-run-nixos-rebuild-install-bootloader> machine # vm-test-run-nixos-rebuild-install-bootloader> machine # error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6) vm-test-run-nixos-rebuild-install-bootloader> machine # error: builder for '/nix/store/x30m3rvz7j39imcm6i25mf444kiavlbp-acl-2.3.1.tar.gz.drv' failed with exit code 1 vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/61ldkx9h66hvmfyksplgks3080dp2m3g-acl-2.3.1.drv' failed to build vm-test-run-nixos-rebuild-install-bootloader> machine # building '/nix/store/c99ihlhb2lh875spzsl6rnc4058grxvn-autoconf-2.71.tar.xz.drv'... vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/ywar7rckmkvkdn7yiw52kh31k4vnyv8p-libarchive-3.7.2.drv' failed to build vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/rjk5kgwkr7d51s41kcbvz5q0rpq5vrq0-cmake-3.26.4.drv' failed to build vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/myqqk3a5av187qavd79ba61qcl06113r-initrd-linux-6.1.59.drv' failed to build vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/nly2ma5j7dksc2c6nb9zccgdwy6a898k-nixos-system-nixos-23.11pre-git.drv' failed to build ```

Perhaps it's worth adding systemdMinimal (and friends) to installation-device? (Or base?)

thiagokokada · 2023-10-24T09:28:17Z

Looks like the real culprit is missing dependencies to rebuild initrd from within a VM (if we flip back to system.includeBuildDependencies = false;):
$ nix build --no-link -f. nixosTests.nixos-rebuild-install-bootloader -L
vm-test-run-nixos-rebuild-install-bootloader> machine # building '/nix/store/48kwl0adwbwlzw7x261v7w846pq48m3v-users-groups.json.drv'... vm-test-run-nixos-rebuild-install-bootloader> machine # Checking that Nix store paths of all wrapped programs exist... OK vm-test-run-nixos-rebuild-install-bootloader> machine # building '/nix/store/x30m3rvz7j39imcm6i25mf444kiavlbp-acl-2.3.1.tar.gz.drv'... vm-test-run-nixos-rebuild-install-bootloader> machine # building '/nix/store/hbd9bkhy0x7qfnl8p85793hh45yzdzsy-attr-2.5.1.tar.gz.drv'... vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6); retrying in 311 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/attr/attr-2.5.1.tar.gz': Couldn't resolve host name (6); retrying in 301 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6); retrying in 550 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/attr/attr-2.5.1.tar.gz': Couldn't resolve host name (6); retrying in 540 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6); retrying in 1250 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/attr/attr-2.5.1.tar.gz': Couldn't resolve host name (6); retrying in 1090 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6); retrying in 2201 ms vm-test-run-nixos-rebuild-install-bootloader> machine # warning: error: unable to download 'https://mirror.easyname.at/nongnu/attr/attr-2.5.1.tar.gz': Couldn't resolve host name (6); retrying in 2341 ms vm-test-run-nixos-rebuild-install-bootloader> machine # error: vm-test-run-nixos-rebuild-install-bootloader> machine # … writing file '/nix/store/y3yiminrckvhf35fh9q42vjwi0npznji-acl-2.3.1.tar.gz' vm-test-run-nixos-rebuild-install-bootloader> machine # vm-test-run-nixos-rebuild-install-bootloader> machine # error: unable to download 'https://mirror.easyname.at/nongnu/acl/acl-2.3.1.tar.gz': Couldn't resolve host name (6) vm-test-run-nixos-rebuild-install-bootloader> machine # error: builder for '/nix/store/x30m3rvz7j39imcm6i25mf444kiavlbp-acl-2.3.1.tar.gz.drv' failed with exit code 1 vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/61ldkx9h66hvmfyksplgks3080dp2m3g-acl-2.3.1.drv' failed to build vm-test-run-nixos-rebuild-install-bootloader> machine # building '/nix/store/c99ihlhb2lh875spzsl6rnc4058grxvn-autoconf-2.71.tar.xz.drv'... vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/ywar7rckmkvkdn7yiw52kh31k4vnyv8p-libarchive-3.7.2.drv' failed to build vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/rjk5kgwkr7d51s41kcbvz5q0rpq5vrq0-cmake-3.26.4.drv' failed to build vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/myqqk3a5av187qavd79ba61qcl06113r-initrd-linux-6.1.59.drv' failed to build vm-test-run-nixos-rebuild-install-bootloader> machine # error: 1 dependencies of derivation '/nix/store/nly2ma5j7dksc2c6nb9zccgdwy6a898k-nixos-system-nixos-23.11pre-git.drv' failed to build

Perhaps it's worth adding systemdMinimal (and friends) to installation-device? (Or base?)

If this is true nixos-rebuild-specialisations test (also added to the channel blocker in this PR) will also break the Hydra: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/nixos-rebuild-specialisations.nix#L17

CC @vcunat since you already removed nixos-rebuild-install-bootloader.

vcunat · 2023-10-24T09:35:06Z

Hydra says it's OK: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.nixos-rebuild-specialisations.x86_64-linux

trofi · 2023-10-24T09:57:12Z

Hydra says it's OK: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.nixos-rebuild-specialisations.x86_64-linux

Interestingly this one does not have nixos-disk-image in it's build dependencies: https://hydra.nixos.org/build/239318925#tabs-build-deps

While install-bootloader does: https://hydra.nixos.org/build/239312800#tabs-build-deps

roberth · 2023-10-24T10:27:40Z

Most tests don't use a boot loader but boot into the kernel directly. I think it would have to enable virtualisation.useBootLoader. To get a nixos-disk-image.

nixos-discourse · 2023-12-08T00:37:39Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-install-with-custom-flake-results-in-boot-being-world-accessible/34555/17

nixos-rebuild: fix --install-bootloader flag with systemd-run

b269e68

github-actions bot added the 6.topic: nixos label Oct 22, 2023

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Oct 22, 2023

thiagokokada mentioned this pull request Oct 22, 2023

nixos-rebuild with --target-host hangs in github action environment #262686

Closed

ofborg bot requested a review from Profpatsch October 22, 2023 22:10

roberth reviewed Oct 23, 2023

View reviewed changes

nixos/tests/nixos-rebuild-install-bootloader.nix Outdated Show resolved Hide resolved

nixos/tests/nixos-rebuild-install-bootloader.nix Show resolved Hide resolved

thiagokokada added 3 commits October 23, 2023 12:39

nixos/tests: add nixos-rebuild-install-bootloader

ccebc89

nixos/release-combined: add nixos-rebuild-specialisations to release-…

ab3ca40

…combined

nixos/tests: make nixos-rebuild tests x86_64-linux only

65cb8b4

Depends on GRUB2/BIOS.

roberth approved these changes Oct 23, 2023

View reviewed changes

roberth merged commit 4bf1366 into NixOS:master Oct 23, 2023
25 of 27 checks passed

thiagokokada deleted the fix-install-bootloader branch October 23, 2023 13:26

mweinelt reviewed Oct 23, 2023

View reviewed changes

mweinelt mentioned this pull request Oct 23, 2023

nixos/tests: fix nixos-rebuild-specialisations test definition #263032

Merged

13 tasks

vcunat mentioned this pull request Oct 24, 2023

nixos/release-combined: drop nixos-rebuild-install-bootloader #263088

Merged

vcunat added a commit that referenced this pull request Oct 24, 2023

nixos/release-combined: drop nixos-rebuild-install-bootloader

1ec4e9d

... at least until it's fixed. /cc PR #262724 again.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nixos-rebuild: fix --install-bootloader flag with systemd-run #262724

nixos-rebuild: fix --install-bootloader flag with systemd-run #262724

thiagokokada commented Oct 22, 2023 •

edited

Loading

thiagokokada commented Oct 22, 2023

thiagokokada commented Oct 22, 2023 •

edited

Loading

arianvp commented Oct 22, 2023

thiagokokada commented Oct 22, 2023

roberth left a comment

thiagokokada commented Oct 23, 2023 •

edited

Loading

roberth commented Oct 23, 2023

mweinelt commented Oct 23, 2023

mweinelt Oct 23, 2023

vcunat commented Oct 24, 2023

vcunat commented Oct 24, 2023

vcunat commented Oct 24, 2023

trofi commented Oct 24, 2023

thiagokokada commented Oct 24, 2023

vcunat commented Oct 24, 2023

trofi commented Oct 24, 2023

roberth commented Oct 24, 2023

nixos-discourse commented Dec 8, 2023

nixos-rebuild: fix --install-bootloader flag with systemd-run #262724

nixos-rebuild: fix --install-bootloader flag with systemd-run #262724

Conversation

thiagokokada commented Oct 22, 2023 • edited Loading

Description of changes

Things done

thiagokokada commented Oct 22, 2023

thiagokokada commented Oct 22, 2023 • edited Loading

arianvp commented Oct 22, 2023

thiagokokada commented Oct 22, 2023

roberth left a comment

Choose a reason for hiding this comment

thiagokokada commented Oct 23, 2023 • edited Loading

roberth commented Oct 23, 2023

mweinelt commented Oct 23, 2023

mweinelt Oct 23, 2023

Choose a reason for hiding this comment

vcunat commented Oct 24, 2023

vcunat commented Oct 24, 2023

vcunat commented Oct 24, 2023

trofi commented Oct 24, 2023

thiagokokada commented Oct 24, 2023

vcunat commented Oct 24, 2023

trofi commented Oct 24, 2023

roberth commented Oct 24, 2023

nixos-discourse commented Dec 8, 2023

thiagokokada commented Oct 22, 2023 •

edited

Loading

thiagokokada commented Oct 22, 2023 •

edited

Loading

thiagokokada commented Oct 23, 2023 •

edited

Loading