nixos/systemd-boot: Avoid remote mypy executions #263397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbraud
force-pushed
the
runLocal/systemd-boot
branch
from
71f8608
to
964ab3b
Compare
|
Rebased to resolve merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In the systemd-boot NixOS module, set
preferLocalBuildswhen type-checkingsystemd-boot-builder.py, to avoid the overhead of remote builds.This is a second go at this, #261640 wrongly used
runCommandLocalinstead, breaking a NixOS test and blocking the nixos-unstable channel.Many thanks to @vcunat for pointing out
runCommandLocalalso setsallowSubstitutes = false;Things done
installer.simpleUefiSystemdBoot./result/bin/)