Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.flufl-lock: 7.1.1 -> 8.0.2; python311Packages.flufl-i18n: 4.1.1 -> 5.0.2; rename #265198

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

natsukium
Copy link
Member

Description of changes

part of #245383

Changelog: https://gitlab.com/warsaw/flufl.lock/-/blob/8.0.2/docs/NEWS.rst
Changelog: https://gitlab.com/warsaw/flufl.i18n/-/raw/5.0.2/docs/NEWS.rst

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium
Copy link
Member Author

natsukium commented Nov 3, 2023

Result of nixpkgs-review pr 265198 at a490d3a run on aarch64-darwin 1

1 package marked as broken and skipped:
  • dvc-with-remotes
10 packages built successfully:
  • dvc (python311Packages.dvc)
  • python310Packages.dvc
  • python310Packages.dvclive
  • python310Packages.flufl-bounce
  • python310Packages.flufl-i18n
  • python310Packages.flufl-lock
  • python311Packages.dvclive
  • python311Packages.flufl-bounce
  • python311Packages.flufl-i18n
  • python311Packages.flufl-lock

Result of nixpkgs-review pr 265198 at a490d3a run on x86_64-linux 1

2 packages failed to build:
12 packages built successfully:
  • dvc (python311Packages.dvc)
  • dvc-with-remotes
  • mailman-web
  • python310Packages.dvc
  • python310Packages.dvclive
  • python310Packages.flufl-bounce
  • python310Packages.flufl-i18n
  • python310Packages.flufl-lock
  • python311Packages.dvclive
  • python311Packages.flufl-bounce
  • python311Packages.flufl-i18n
  • python311Packages.flufl-lock

Result of nixpkgs-review pr 265198 at 6464cb7 run on x86_64-linux 1

14 packages built successfully:
  • dvc (python311Packages.dvc)
  • dvc-with-remotes
  • mailman
  • mailman-hyperkitty
  • mailman-web
  • python310Packages.dvc
  • python310Packages.dvclive
  • python310Packages.flufl-bounce
  • python310Packages.flufl-i18n
  • python310Packages.flufl-lock
  • python311Packages.dvclive
  • python311Packages.flufl-bounce
  • python311Packages.flufl-i18n
  • python311Packages.flufl-lock

# error: Command '['/nix/store/s6fgyqbk8vn1014daznm5kqx90xdn86x-python3-3.10.13/bin/python3.10', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/build/tmp9yk3_jzi', '--quiet', 'flufl.lock>=5.1']' returned non-zero exit status 1.
# There are so many network related errors and it is difficult to run pytestCheckHook.
# (1822 failed, 164 passed, 2 xfailed, 26 warnings, 11 errors)
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this just mean we're missing checkInputs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, perhaps not. Because flufl-lock is already included in propagatedBuildInputs.
This sphinxcontrib_newsfeed case reported "missing docutils", but docutils was unrelated.
#263504 #264924

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others have a similar issue with flufl switching to pdm: iterative/dvc#9654

if we drop the updates e41e58e, a490d3a and enable the mailman checks 6464cb7 (drop commit) everything keeps working...

@Stunkymonkey
Copy link
Contributor

@natsukium you have to remove some commits, because #285868 was merged. Or do you want to close it?

Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants