Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.bash-kernel: rename from bash_kernel #266657

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

mweinelt
Copy link
Member

Description of changes

Part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Substitute the bash path more carefully, as not all quoted bash strings
are meant to be paths.
@natsukium
Copy link
Member

natsukium commented Nov 12, 2023

Result of nixpkgs-review pr 266657 at 403a240 run on x86_64-linux 1

2 packages built successfully:
  • python310Packages.bash-kernel
  • python311Packages.bash-kernel

Result of nixpkgs-review pr 266657 at 403a240 run on aarch64-darwin 1

2 packages built successfully:
  • python310Packages.bash-kernel
  • python311Packages.bash-kernel

@natsukium natsukium merged commit 18cb953 into NixOS:master Nov 12, 2023
26 checks passed
@mweinelt mweinelt deleted the bash-kernel-rename branch November 12, 2023 10:58
@thomasjm
Copy link
Contributor

Hi all, I have a question here --

Is there a reason this PR removed the patch https://patch-diff.githubusercontent.com/raw/takluyver/bash_kernel/pull/69.diff ?

I see that some other patch was applied to the same area. (And there might have been some upstream changes there too.) But I'm experiencing a breaking with this package and I think it's because that patch was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants