Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copier: 8.1.0 -> 8.3.0 #268738

Closed
wants to merge 1 commit into from
Closed

copier: 8.1.0 -> 8.3.0 #268738

wants to merge 1 commit into from

Conversation

carlthome
Copy link
Contributor

@carlthome carlthome commented Nov 20, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@carlthome carlthome force-pushed the bump-copier branch 2 times, most recently from 196c8f4 to fcf2c9b Compare November 20, 2023 15:31
@carlthome
Copy link
Contributor Author

Getting

ImportError: cannot import name 'AfterValidator' from 'pydantic'

at runtime with nix run .#copier -- --version so something is missing.

@carlthome
Copy link
Contributor Author

Think it's related to that copier now assumes Pydantic 2, so think this is technically blocked by #244564

@carlthome
Copy link
Contributor Author

Yup: copier-org/copier@v8.1.0...v8.3.0

@carlthome
Copy link
Contributor Author

Related #263228

@carlthome
Copy link
Contributor Author

If anyone is reading this, looking for a work around, here's how you can run the latest copier with Nix:

nix run github:copier-org/copier -- --version

since fortunately upstream already packages their software with Nix.

@ofborg ofborg bot requested a review from jonringer November 20, 2023 16:51
@GTrunSec
Copy link
Contributor

  • nix run github:copier-org/copier -- --version
  • passed on x86_64-linux
copier 9.0.1.dev20231121164554+nix.git.50d478e

@carlthome
Copy link
Contributor Author

@GTrunSec this should not be merged. Build works but runtime fails.

@natsukium natsukium marked this pull request as draft November 24, 2023 04:22
@wegank
Copy link
Member

wegank commented Jan 30, 2024

Superseded by #282479.

@wegank wegank closed this Jan 30, 2024
@carlthome carlthome deleted the bump-copier branch January 30, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GTrunSec GTrunSec GTrunSec approved these changes

@LudovicoPiero LudovicoPiero Awaiting requested review from LudovicoPiero

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlthome @GTrunSec @wegank @delroth