Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.pydantic: 1.10.9 -> 2.0.3 #244564

Closed
wants to merge 2 commits into from

Conversation

blaggacao
Copy link
Contributor

Description of changes

Pydantic V2 is a ground-up rewrite that offers many new features, performance improvements, and some breaking changes compared to Pydantic V1.
If you're using Pydantic V1 you may want to look at the pydantic V1.10 Documentation or, 1.10.X-fixes git branch. Pydantic V2 also ships with the latest version of Pydantic V1 built in so that you can incrementally upgrade your code base and projects: from pydantic import v1 as pydantic_v1.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jul 20, 2023
@blaggacao blaggacao force-pushed the update-pydantic-to-v2 branch 3 times, most recently from 736c1e3 to 0734be7 Compare July 20, 2023 23:13
@ofborg ofborg bot requested review from fabaff and wd15 July 20, 2023 23:31
@mweinelt
Copy link
Member

We cannot support multiple versions of the same package, because PYTHONPATHs only ever support one version. And since the PYTHONPATH gets cobbled together transitively this is very likely to happen, especially for popular packages like pydantic.

It's going to have to be either one or the other, not both.

@mweinelt mweinelt marked this pull request as draft July 20, 2023 23:36
@wegank
Copy link
Member

wegank commented Oct 24, 2023

Merge conflict, please rebase.

@mweinelt
Copy link
Member

This approach isn't feasible, as described in #244564 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants