Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/amazon: drop #269240

Closed
wants to merge 4 commits into from
Closed

nixos/amazon: drop #269240

wants to merge 4 commits into from

Conversation

RaitoBezarius
Copy link
Member

Description of changes

This is a PR dropping all the Amazon stuff that is unmaintained in nixpkgs. Read commits for details.

Feel free to revert and add yourself as a maintainer if you care about a particular piece.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@RaitoBezarius
nixos/tests/ec2: drop
e86c6f7 
This test has been marked as broken for a long time,
it seems that no one is really owning it and this is a waste of our resources.

Feel free to revert and add yourself as a maintainer
if you care about this.
@RaitoBezarius
nixos/release: drop amazonImage, amazonImageZfs, `amazonImageAuto…
0fc8151 
…maticSize`

All of those attributes are broken and given the sad state of AWS maintenance,
I am inclined to remove them and stop advertising a support of things
that we do not support in fact.

Feel free to revert and add yourself as a maintainer.
@RaitoBezarius
maintainers/scripts/ec2: drop the AMI creation script
6626120 
The release management process involves uploading functional AMIs
at each release for NixOS.

As this script mentions, the 'entire thing' should be replaced with a new setup
involving Terraform.

Such a new setup can be found in NixOS/infra#254.

In the meantime, this script should not be used anymore until a better solution for AMI uploading is
found.

This means effectively that AMI uploading is not part of the release management process for further
releases.

Feel free to push forward the PR mentioned to get back AMI upload.
@RaitoBezarius RaitoBezarius changed the title amazon: drop nixos/amazon: drop Nov 22, 2023
@RaitoBezarius RaitoBezarius marked this pull request as ready for review November 22, 2023 17:46
@RaitoBezarius RaitoBezarius mentioned this pull request Nov 22, 2023
Closed
@cole-h
Copy link
Member

cole-h commented Nov 22, 2023 •
edited

In the case that the brokenness is not "can't build with Nix" but something else, could you please explain what exactly is broken in the individual commits?

I just recently tried to fix the build of the ZFS image by fixing zpool-auto-expand-partitions in #268562 (which may or may not be contributing to the problem 🤷) and was confused at what could be broken if I was able to fix the build failure.

The issue is that, at least in the ZFS image's case, QEMU appears to hang while building the image, as you can see by this log output:

If anybody wants to fix this up now or after the fact, it'd be nice to have the details of what's actually broken (especially since the initial interpretation of "broken" is "the Nix build fails", not "this doesn't work right", at least for me / in this repository) :)

@cole-h
Copy link
Member

cole-h commented Nov 22, 2023 •
edited

I was wrong about the ZFS image, I was able to finish building it just fine on bcc0da2, though it did take a while:

$ nix-build nixos/release.nix -A amazonImageZfs.x86_64-linux
[...snip...]
++ mv /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos.boot.vhd /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.boot.vhd
++ mkdir -p /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nix-support
++ echo 'file vpc /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.boot.vhd'
++ echo 'file vpc /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.root.vhd'
+++ /nix/store/v6r36lyl0c6cjd9n4d9vhqqwh1vrisdh-qemu-host-cpu-only-8.1.2/bin/qemu-img info --output json /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.root.vhd
+++ /nix/store/bpjd8324a6qj34zxhn5asgvi8bpm9bb2-jq-1.7-bin/bin/jq '."virtual-size"'
+++ /nix/store/v6r36lyl0c6cjd9n4d9vhqqwh1vrisdh-qemu-host-cpu-only-8.1.2/bin/qemu-img info --output json /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.boot.vhd
+++ /nix/store/bpjd8324a6qj34zxhn5asgvi8bpm9bb2-jq-1.7-bin/bin/jq '."virtual-size"'
++ /nix/store/bpjd8324a6qj34zxhn5asgvi8bpm9bb2-jq-1.7-bin/bin/jq -n --arg system_label 24.05beta-420383.gfedcba --arg system x86_64-linux --arg root_logical_bytes 3221471232 --arg boot_logical_bytes 1048707072 --arg boot_mode legacy-bios --arg root /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.root.vhd --arg boot /nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux/nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux.boot.vhd '{}
   | .label = $system_label
   | .boot_mode = $boot_mode
   | .system = $system
   | .disks.boot.logical_bytes = $boot_logical_bytes
   | .disks.boot.file = $boot
   | .disks.root.logical_bytes = $root_logical_bytes
   | .disks.root.file = $root
   '
/nix/store/b7avpbgx40qq46wm74ya0mwz00s1dk5q-nixos-amazon-image-24.05beta-420383.gfedcba-x86_64-linux

So at least this image doesn't seem broken to me :)

@RaitoBezarius
Copy link
Member Author

@cole-h Let me get you my traces.

@cole-h
Copy link
Member

cole-h commented Nov 22, 2023 •
edited

Just to be clear, I'm not signing up to help maintain this stuff (I very, very rarely use AWS EC2), but I think citing the reason for removal as "being broken", when it's not broken, is a bit weird :)

@RaitoBezarius
Copy link
Member Author

Amazon image: https://clbin.com/TVz4l (initially had a store corrupting bug with hash mismatch at install time, but that's Nix fault.)
Amazon image ZFS: it OOM for me, will try to get a proper log for it again but might be transient.

@RaitoBezarius
Copy link
Member Author

Just to be clear, I'm not signing up to help maintain this stuff (I very, very rarely use AWS EC2), but I think citing the reason for removal as "being broken", when it's not broken, is a bit weird :)

Yeah, you are right, I can be more precise in the individual commits about the reasons.

@arianvp
Copy link
Member

arianvp commented Nov 22, 2023

I will open a PR to add myself as maintainer instead of dropping. I have no interest in maintaining zfs support though as we don't use it At work

@Artturin
Copy link
Member

There's a pending amis pr #263075

@RaitoBezarius
Copy link
Member Author

@arianvp If you can send an ownership taking PR, I will close this one in the time being.

@anthonyroussel anthonyroussel mentioned this pull request Dec 1, 2023
Closed
13 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/ami-for-nixos-23-11/36860/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RaitoBezarius @cole-h @arianvp @Artturin @nixos-discourse