endlines: init at 1.9.2 #271173
Merged
endlines: init at 1.9.2 #271173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclairevoyant
requested changes
Nov 30, 2023
eclairevoyant
approved these changes
Nov 30, 2023
AndersonTorres
suggested changes
Nov 30, 2023
AndersonTorres
suggested changes
Dec 1, 2023
AndersonTorres
approved these changes
Dec 2, 2023
|
@ofborg eval |
AndersonTorres
approved these changes
Dec 6, 2023
|
Is anything else required to be able to merge this? All checks have passed and it's been reviewed by two reviewers. |
|
I will send this to the Discourse. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1293 |
pbsds
reviewed
Dec 10, 2023
philiptaron
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
endlinesis a command-line utility for conversion of line-endings in files and entire directories.The repository comes with a
testsdirectory, but they're broken.Homepage: https://github.com/mdolidon/endlines
This is my first contribution here, and I'm still learning Nix. Any feedback is welcome.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.