Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elisp updates #272032

Closed
wants to merge 4 commits into from
Closed

Elisp updates #272032

wants to merge 4 commits into from

Conversation

AndersonTorres
Copy link
Member

Description of changes

Triggered by #272019

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it should target staging and ofborg has not triggered any builds for these changes.

@leungbk
Copy link
Member

leungbk commented Dec 5, 2023

this looks like it should target staging and ofborg has not triggered any builds for these changes.

In the past, we've had permission to bypass staging and target master directly since these rebuilds are for Elisp packages.

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Dec 5, 2023

Emacs Lisp packages are a "mass rebuild" because they are legion, not because they are reverse dependencies of the whole system.

@AndersonTorres
Copy link
Member Author

Since that idea of throwing Emacs on staging, I will close this.

#272984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants