WIP: Python no runtime deps at build time #272179
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes dependency propagation from
buildPythonPackage
when a runtime dependency is passed viadependencies
.Please don't actually review the code yet. This a a very WIP, very draft PoC & should be considered a demo for #272178.
This also includes the commits from #271597.
Only the commits prefixed with WIP: are a part of this.
python3Packages.foo
Depending on a Python package like this will break:
You will instead need to:
This is because dependencies are no longer build-time propagated, so the full dependency graph calculation needs to happen in the Nix evaluator.
python3Packages.buildPythonPackage
vspython3Packages.buildPythonApplication
buildPythonPackage
is for building a Python package without dependency propagationbuildPythonApplication
is for building application bundles. This internally callsbuildPythonPackage
, and also creates a wrapper derivation that takes care of callingrequiredPythonModules
.All Python applications which has runnable binaries now needs to either be:
buildPythonApplication
toPythonApplication
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.