espresso: init at 2.4 #272597
Merged
espresso: init at 2.4 #272597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pineapplehunter
force-pushed
the
espresso
branch
2 times, most recently
from
50adead
to
fe00295
Compare
|
Added sourceProvenance. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3203 |
NickCao
reviewed
Jan 4, 2024
pkgs/by-name/es/espresso/package.nix
Outdated
| owner = "chipsalliance"; | ||
| repo = pname; | ||
| rev = "v${version}"; | ||
| sha256 = "sha256-z5By57VbmIt4sgRgvECnLbZklnDDWUA6fyvWVyXUzsI="; |
There was a problem hiding this comment.
Suggested change
| sha256 = "sha256-z5By57VbmIt4sgRgvECnLbZklnDDWUA6fyvWVyXUzsI="; | |
| hash = "sha256-z5By57VbmIt4sgRgvECnLbZklnDDWUA6fyvWVyXUzsI="; |
pkgs/by-name/es/espresso/package.nix
Outdated
| version = "2.4"; | ||
| src = fetchFromGitHub { | ||
| owner = "chipsalliance"; | ||
| repo = pname; |
There was a problem hiding this comment.
Suggested change
| repo = pname; | |
| repo = "espresso"; |
pkgs/by-name/es/espresso/package.nix
Outdated
| sha256 = "sha256-z5By57VbmIt4sgRgvECnLbZklnDDWUA6fyvWVyXUzsI="; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ cmake ninja ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ cmake ninja ]; | |
| nativeBuildInputs = [ cmake ]; |
ninja is only faster on incremental builds.
pkgs/by-name/es/espresso/package.nix
Outdated
|
|
||
| nativeBuildInputs = [ cmake ninja ]; | ||
|
|
||
| enableParallelBuilding = true; |
There was a problem hiding this comment.
Suggested change
| enableParallelBuilding = true; |
cmake already sets this by default.
pkgs/by-name/es/espresso/package.nix
Outdated
| passthru.updateScript = nix-update-script { }; | ||
|
|
||
| meta = with lib;{ | ||
| description = "Espresso is a Multi-valued PLA minimization."; |
There was a problem hiding this comment.
Suggested change
| description = "Espresso is a Multi-valued PLA minimization."; | |
| description = "Multi-valued PLA minimization"; |
pkgs/by-name/es/espresso/package.nix
Outdated
| maintainers = with maintainers;[ pineapplehunter ]; | ||
| mainProgram = "espresso"; | ||
| platforms = lib.platforms.all; | ||
| sourceProvenance = with lib.sourceTypes;[ fromSource ]; |
There was a problem hiding this comment.
No need to mark sourceProvenance explicitly for source builds.
Suggested change
| sourceProvenance = with lib.sourceTypes;[ fromSource ]; |
pineapplehunter
force-pushed
the
espresso
branch
from
fe00295
to
7ebba97
Compare
|
@NickCao Thanks for the review! |
|
Result of 2 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The license is set ro unfree, since the source on github does not provide a licence. See: chipsalliance/espresso#4
cc: @sequencer
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.