Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312: 3.12.0 -> 3.12.1 #272944

Merged
merged 1 commit into from Dec 8, 2023
Merged

python312: 3.12.0 -> 3.12.1 #272944

merged 1 commit into from Dec 8, 2023

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 8, 2023

https://docs.python.org/release/3.12.1/whatsnew/changelog.html

Fixes: CVE-2023-6507

gh-112334: Fixed a performance regression in 3.12鈥檚 subprocess on Linux where it would no longer use the fast-path vfork() system call when it should have due to a logic bug, instead always falling back to the safe but slower fork().

Also fixed a related 3.12 security regression: If a value of extra_groups=[] was passed to subprocess.Popen or related APIs, the underlying setgroups(0, NULL) system call to clear the groups list would not be made in the child process prior to exec(). This has been assigned CVE-2023-6507.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@mweinelt mweinelt added the backport release-23.11 Backport PR automatically label Dec 8, 2023
@mweinelt mweinelt requested a review from FRidh as a code owner December 8, 2023 16:05
@mweinelt mweinelt changed the base branch from staging to master December 8, 2023 16:05
@mweinelt mweinelt merged commit 4fef1f7 into NixOS:master Dec 8, 2023
29 of 30 checks passed
@mweinelt mweinelt deleted the python-3.12.1 branch December 8, 2023 23:13
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant